nomind60s <nomind60s@users.noreply.github.com>: Author Summary
Build | Completed | Code commits | Tests |
---|---|---|---|
PHPBB3 › PR › #7216 | 6 years ago | 1 of 6610 failed | |
PHPBB3 › DDM › #189 | 6 years ago |
[ticket/14498] Don't display 'Who is online' members when permission is No
When the user permission 'Can view profiles, memberlist and online list' is set to No (or Never) the user should not be able to see which members are online in the following places, index page, view topic and view forum. Before this change, guests and bots would see the list of members who are online, which doesn't match with the user permission and could create privacy issues where guests or bots could track when a member was online. PHPBB3-14498 |
6654 passed |
PHPBB3 › DD32 › #308 | 6 years ago |
[ticket/14498] Don't display 'Who is online' members when permission is No
When the user permission 'Can view profiles, memberlist and online list' is set to No (or Never) the user should not be able to see which members are online in the following places, index page, view topic and view forum. Before this change, guests and bots would see the list of members who are online, which doesn't match with the user permission and could create privacy issues where guests or bots could track when a member was online. PHPBB3-14498 |
6609 passed |
PHPBB3 › DDM › #167 | 6 years ago |
[ticket/15086] Move RTL Font Awesome icon to icons.css
Per github discussion, move the RTL Font Awesome coding from bidi.css to icons.css. PHPBB3-15086 [ticket/15086] Remove properties that are no longer used
PHPBB3-15086 [ticket/15086] Merge cite and uncited definitions
Per hanakin's suggested changes, merged the cite and uncited definitions. Handle the uncited case in RTL languages. PHPBB3-15086 [ticket/15086] Rework specification of properties to simplify
Once more rework the property specifications to maintain backwards compatability and keep changes as small as possible. Thanks hanakin for the assistance. PHPBB3-15086 [ticket/15086] Handle the uncited case properly
The blockquote uncited CSS needs the Font Awesome icon added as well PHPBB3-15086 [ticket/15086] Refactoring and moving to icons.css
Per hanakin's github suggestions some refactoring and moved icons into icons.css for conistency. The RTL icons remain in bidi.css to keep all the RTL content in a consistant location. A number of places where setting something to zero have been removed. PHPBB3-15086 [ticket/15086] corrections from vinny's review
Changed instances of 0px; to 0; and add missing element PHPBB3-15086 [ticket/15086] Replace quote.gif with Font Awesome icon
Use the Font Awesome icon for a quote rather than the quote.gif file. I believe I've handled the RTL case as well. PHPBB3-15086 |
Testless build |
PHPBB3 › DD32 › #290 | 6 years ago |
[ticket/15086] Rework specification of properties to simplify
Once more rework the property specifications to maintain backwards compatability and keep changes as small as possible. Thanks hanakin for the assistance. PHPBB3-15086 [ticket/15086] corrections from vinny's review
Changed instances of 0px; to 0; and add missing element PHPBB3-15086 [ticket/15086] Handle the uncited case properly
The blockquote uncited CSS needs the Font Awesome icon added as well PHPBB3-15086 [ticket/15086] Replace quote.gif with Font Awesome icon
Use the Font Awesome icon for a quote rather than the quote.gif file. I believe I've handled the RTL case as well. PHPBB3-15086 [ticket/15086] Move RTL Font Awesome icon to icons.css
Per github discussion, move the RTL Font Awesome coding from bidi.css to icons.css. PHPBB3-15086 [ticket/15086] Remove properties that are no longer used
PHPBB3-15086 [ticket/15086] Refactoring and moving to icons.css
Per hanakin's github suggestions some refactoring and moved icons into icons.css for conistency. The RTL icons remain in bidi.css to keep all the RTL content in a consistant location. A number of places where setting something to zero have been removed. PHPBB3-15086 [ticket/15086] Merge cite and uncited definitions
Per hanakin's suggested changes, merged the cite and uncited definitions. Handle the uncited case in RTL languages. PHPBB3-15086 |
Testless build |
PHPBB3 › PR › #7028 | 6 years ago |
[ticket/15151] ACP Cookie settings explanatory text
Fixed extraneous whitespace at end of line. PHPBB3-15151 [ticket/15151] ACP Cookie settings add explanatory text where it was missing
Improve the lead section to include a link to the phpBB.com Knowledge Base and add explanation text for the Cookie domain, Cookie name and Cookie path fields. PHPBB3-15151 [ticket/15151] Use redirected link for consistency
Other phpbb.com links used in the core use a redirect rather than a direct link so change to make the Cookie settings link a redirect also. PHPBB3-15151 |
5593 passed |
PHPBB3 › DDM › #155 | 6 years ago |
[ticket/15151] ACP Cookie settings add explanatory text where it was missing
Improve the lead section to include a link to the phpBB.com Knowledge Base and add explanation text for the Cookie domain, Cookie name and Cookie path fields. PHPBB3-15151 [ticket/15151] Use redirected link for consistency
Other phpbb.com links used in the core use a redirect rather than a direct link so change to make the Cookie settings link a redirect also. PHPBB3-15151 [ticket/15151] ACP Cookie settings explanatory text
Fixed extraneous whitespace at end of line. PHPBB3-15151 |
6596 passed |
Build | Completed | Code commits | Tests |
---|---|---|---|
PHPBB3 › DDM › #138 | 6 years ago |
[ticket/15137] Global announcements can stick for a non-zero number of days
To be consistent with Sticky and Announcements topic types, Global announcements can now stick for a non-zero number of days, i.e. they are no longer never ending. Before this change, if the topic type was Global and a non-zero number of days where set to stick topic, the number was silently ignored and a Global announcement was always never ending. PHPBB3-15137 [ticket/15137] Missed one language string change
Change STICKY_ANNOUNCE_TIME_LIMIT for consistency PHPBB3-15137 |
Testless build |
Build | Completed | Code commits | Tests |
---|
When the user permission 'Can view profiles, memberlist and online list' is
set to No (or Never) the user should not be able to see which members are
online in the following places, index page, view topic and view forum.
Before this change, guests and bots would see the list of members who are
online, which doesn't match with the user permission and could create privacy
issues where guests or bots could track when a member was online.
PHPBB3-14498