Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13735

Prosilver bug when posting & adding poll (at least)

    XMLWordPrintable

Details

    Description

      I have found what looks like a bug in prosilver.

      Take a look at attached file.

      There is a gap between the up&down arrows to modify the value and the end of the field. It corresponds to the following HTML code (posting_editor.html line 163):

      <dd><label for="topic_time_limit"><input type="number" min="0" max="999" name="topic_time_limit" id="topic_time_limit" size="3" maxlength="3" value="{TOPIC_TIME_LIMIT}" class="inputbox autowidth" /> {L_DAYS}</label></dd>
      

      This is simply fixed by changing to:

      <dd><input type="number" min="0" max="999" name="topic_time_limit" id="topic_time_limit" size="3" maxlength="3" value="{TOPIC_TIME_LIMIT}" class="inputbox autowidth" /><label for="topic_time_limit"> {L_DAYS}</label></dd>
      

      There might be other ways to fix it, but just providing one simple way that has worked for me.

      This is happening at least in one other place (in the Poll tab). This is the other HTML code where it happens (posting_poll_body.html line 34)

      <dd><label for="poll_length"><input type="number" min="0" max="999" name="poll_length" id="poll_length" size="3" maxlength="3" value="{POLL_LENGTH}" class="inputbox autowidth" /> {L_DAYS}</label></dd>
      

      Fixed by changing to:

      <dd><input type="number" min="0" max="999" name="poll_length" id="poll_length" size="3" maxlength="3" value="{POLL_LENGTH}" class="inputbox autowidth" /><label for="poll_length"> {L_DAYS}</label></dd>
      

      The fix is leaving the <input> tag out of the <label> tag around it, to avoid for an extra width element.

      There might be other places where this is happening, if there is an <input type="number"> tag inside a <label> tag.

      Could anyone please:
      1) Confirm this is indeed a bug?
      2) Confirm whether there are other places where this happens?
      3) Confirm that my proposed fix is a correct one? Or, alternatively, provide a better fix (maybe just CSS)...

      Thanks and best regards,
      -javiexin

      Attachments

        Activity

          People

            nicofuma nicofuma
            javiexin javiexin [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: