Build: #590 was successful Changes by Marc

Stages & jobs

  1. Default Stage

Code commits

phpBB Rhea

  • Marc

    Marc a02524e7fcf26f380889d541255f4738e3eabe76

    Merge pull request #5633 from kasimi/ticket/16108
    [ticket/16108] Add topiclist_row_topic_by_author_before|after

  • Marc

    Marc 207b678896d8d46f8e5b5cca05beffcbd89e11d3

    Merge pull request #5632 from kasimi/ticket/16107
    [ticket/16107] Add mcp_move_destination_forum_before|after

  • Marc

    Marc 51205febe37e0df26eafa966ddcf32015ef62d6e

    Merge pull request #5635 from EA117/ticket/16066
    [ticket/16066] Fix FORM_INVALID always returned for banned user.

  • Marc

    Marc 6440f97a4f40020132da79d41391651ee60802d9

    Merge pull request #5638 from marc1706/ticket/16112
    [ticket/16112] Update composer dependencies for 3.2.x

  • Marc

    Marc 40849396203a02772906b9419f805f032c355690 m

    [ticket/16112] Update composer dependencies for 3.2.x
    PHPBB3-16112

    • phpBB/composer.json (version 40849396203a02772906b9419f805f032c355690)
    • phpBB/composer.lock (version 40849396203a02772906b9419f805f032c355690)
  • EA117

    EA117 636fc7fad7dcb61622f23b36141b87ee13a1090d m

    [ticket/16066] Fix FORM_INVALID always returned for banned user.
    After the introduction of add_form_key() and check_form_key() calls to
    login_box() in phpBB 3.2.6 and later, if a banned user attempts to login,
    they receive a "The submitted form was invalid. Try submitting again."
    Instead of the message indicating that they are banned, and why.

    This is happening because check_ban() actually calls into login_box()
    recursively, but after the $user->session_id has been switched to a new
    session ID for the logging-on user.  Therefore, now that check_form_key()
    has been introduced to login_box(), it is impossible for check_form_key()
    to succeed during this recursive call.

    Fix is to make login_box()'s use of check_form_key() conditional on whether
    IN_CHECK_BAN is defined, so that the recursive call does not attempt to
    re-validate the form_key again.  Note the form_key has already been
    successfully verified by the original call into login_box(), prior to calling
    into check_ban() and attempting to recursively call login_box().  So the
    protection of why check_form_key() was added is still intact with this change.

    PHPBB3-16066

    • phpBB/includes/functions.php (version 636fc7fad7dcb61622f23b36141b87ee13a1090d)
  • Marc

    Marc 179f5c75edcdec0c3857b7f9520eb24413b0bc56 m

    [ticket/16108] Use twig syntax in template event
    PHPBB3-16108

    • phpBB/styles/prosilver/template/mcp_forum.html (version 179f5c75edcdec0c3857b7f9520eb24413b0bc56)
    • phpBB/styles/prosilver/template/search_results.html (version 179f5c75edcdec0c3857b7f9520eb24413b0bc56)
    • phpBB/styles/prosilver/template/viewforum_body.html (version 179f5c75edcdec0c3857b7f9520eb24413b0bc56)
  • Marc

    Marc 1a00b4a5658fa98fa86f9c596387c23dcc63408d m

    [ticket/16107] Use twig syntax for event
    PHPBB3-16107

    • phpBB/styles/prosilver/template/mcp_move.html (version 1a00b4a5658fa98fa86f9c596387c23dcc63408d)
  • kasimi <mail@kasimi.net>

    kasimi <mail@kasimi.net> 7a5470161243b300b5377c22876126ecf3de8f6c m

    [ticket/16108] Add topiclist_row_topic_by_author_before|after
    PHPBB3-16108

    • phpBB/docs/events.md (version 7a5470161243b300b5377c22876126ecf3de8f6c)
    • phpBB/styles/prosilver/template/mcp_forum.html (version 7a5470161243b300b5377c22876126ecf3de8f6c)
    • phpBB/styles/prosilver/template/search_results.html (version 7a5470161243b300b5377c22876126ecf3de8f6c)
    • phpBB/styles/prosilver/template/viewforum_body.html (version 7a5470161243b300b5377c22876126ecf3de8f6c)
  • kasimi <mail@kasimi.net>

    kasimi <mail@kasimi.net> 2bb08f853ea6ed60987f9886cd72eaa74ebd6c44 m

    [ticket/16107] Add mcp_move_destination_forum_before|after
    PHPBB3-16107

    • phpBB/docs/events.md (version 2bb08f853ea6ed60987f9886cd72eaa74ebd6c44)
    • phpBB/styles/prosilver/template/mcp_move.html (version 2bb08f853ea6ed60987f9886cd72eaa74ebd6c44)