Code commits
phpBB Rhea
-
Marc 1c3585f575bde4f838e15af6f1961a0b158df973
Merge pull request #5920 from mrgoldy/ticket/13867
[ticket/13867] Manage new profile field types -
mrgoldy <gijsmartens1@gmail.com> c8e92608fdaecd673a865bcce1888cfef96eed4f m
[ticket/13867] Correct constructor comment for db tools
PHPBB3-13867- phpBB/phpbb/profilefields/manager.php (version c8e92608fdaecd673a865bcce1888cfef96eed4f)
-
mrgoldy <gijsmartens1@gmail.com> 7149349e2582a069cbfe70650e5a60533df49274 m
[ticket/13867] Use order by in profile fields manager test
PHPBB3-13867- tests/profilefields/manager_test.php (version 7149349e2582a069cbfe70650e5a60533df49274)
-
mrgoldy <gijsmartens1@gmail.com> 9080a0e778616bdd7e1102eb5b81989f2f318341 m
[ticket/13867] Force data type in profile fields manager
PHPBB3-13867- phpBB/phpbb/profilefields/manager.php (version 9080a0e778616bdd7e1102eb5b81989f2f318341)
-
mrgoldy <gijsmartens1@gmail.com> d26e0423f7f457fceae807d320b2f351e4f5b610 m
[ticket/13867] Amend profile fields manager constructor
PHPBB3-13867- phpBB/phpbb/profilefields/manager.php (version d26e0423f7f457fceae807d320b2f351e4f5b610)
-
mrgoldy <gijsmartens1@gmail.com> b602e0c0140a63e5967f8ccc53b7ee8f4689984d m
[ticket/13867] Remove profile field test prophecy
PHPBB3-13867- tests/test_framework/phpbb_test_case.php (version b602e0c0140a63e5967f8ccc53b7ee8f4689984d)
-
mrgoldy <gijsmartens1@gmail.com> 29d44973a7ffb481b0bc8d41eb9618e7c10af357 m
[ticket/13867] Finish profile fields manager tests
PHPBB3-13867- tests/profilefields/manager_test.php (version 29d44973a7ffb481b0bc8d41eb9618e7c10af357)
-
mrgoldy <gijsmartens1@gmail.com> 903185a69c430ce7651d716c83cd580df8edb6bc m
[ticket/13867] Amend profile fields manager tests
PHPBB3-13867- tests/profilefields/manager_test.php (version 903185a69c430ce7651d716c83cd580df8edb6bc)
-
mrgoldy <gijsmartens1@gmail.com> 84cd7e496b1140f39f781c35cfbd87be45b9711d m
[ticket/13867] Amend profile fields manager
PHPBB3-13867- phpBB/config/default/container/services_profilefield.yml (version 84cd7e496b1140f39f781c35cfbd87be45b9711d)
- phpBB/phpbb/profilefields/manager.php (version 84cd7e496b1140f39f781c35cfbd87be45b9711d)
- tests/profilefields/manager_test.php (version 84cd7e496b1140f39f781c35cfbd87be45b9711d)
-
nicofuma b3f3886cd90f5d675e552455d2e6eb7b2143972c m
[ticket/13867] Add tests
PHPBB3-13867- phpBB/includes/acp/acp_profile.php (version b3f3886cd90f5d675e552455d2e6eb7b2143972c)
- phpBB/phpbb/profilefields/manager.php (version b3f3886cd90f5d675e552455d2e6eb7b2143972c)
- tests/profilefields/fixtures/manager.xml (version b3f3886cd90f5d675e552455d2e6eb7b2143972c)
- tests/profilefields/manager_test.php (version b3f3886cd90f5d675e552455d2e6eb7b2143972c)
- tests/test_framework/phpbb_test_case.php (version b3f3886cd90f5d675e552455d2e6eb7b2143972c)
-
javiexin <javiexin@gmail.com> b1e1ee7d55af22ea16184db7bf405dff4557a940 m
[ticket/13867] Enable/disable mechanism for new profile field types
Adds methods to enable, disable and purge profile field types to the
profilefields\manager class. These methods are to be called from
extensions that add new profile field types on the enable, disable
and purge methods of the ext class. If not done, any profile field
of a new type that is left after extension is disabled or removed will
break the forum in several places.
Remove dependency from container, add dependencies with specific classes.
Change try/catch by !isset.
Execute requested changes: more meaningful var names, json_encode, empty.
Execute requested changes: separate a utilit list function, use
sql_in_set, use single quotes ('). Remove code approved in a different PR.
PHPBB3-13867- phpBB/includes/acp/acp_profile.php (version b1e1ee7d55af22ea16184db7bf405dff4557a940)
- phpBB/phpbb/profilefields/manager.php (version b1e1ee7d55af22ea16184db7bf405dff4557a940)
-
javiexin <javiexin@gmail.com> b60322f72931573ff8bfb48d857b9a84a175263d m
[ticket/13867] Enable/disable mechanism for new profile field types
Adds methods to enable, disable and purge profile field types to the
profilefields\manager class. These methods are to be called from
extensions that add new profile field types on the enable, disable
and purge methods of the ext class. If not done, any profile field
of a new type that is left after extension is disabled or removed will
break the forum in several places.
Remove dependency from container, add dependencies with specific classes.
Change try/catch by !isset.
Execute requested changes: more meaningful var names, json_encode, empty.
PHPBB3-13867- phpBB/phpbb/profilefields/manager.php (version b60322f72931573ff8bfb48d857b9a84a175263d)
-
javiexin <javiexin@gmail.com> b89539a70e1fa315b944a0e711208db170ebf079 m
[ticket/13867] Enable/disable mechanism for new profile field types
Adds methods to enable, disable and purge profile field types to the
profilefields\manager class. These methods are to be called from
extensions that add new profile field types on the enable, disable
and purge methods of the ext class. If not done, any profile field
of a new type that is left after extension is disabled or removed will
break the forum in several places.
Remove dependency from container, add dependencies with specific classes.
Change try/catch by !isset.
PHPBB3-13867- phpBB/config/default/container/services_profilefield.yml (version b89539a70e1fa315b944a0e711208db170ebf079)
- phpBB/phpbb/profilefields/manager.php (version b89539a70e1fa315b944a0e711208db170ebf079)
-
javiexin <javiexin@gmail.com> 78ea30860800e5e58bf8d7b8cfbbcaf08193dece m
[ticket/13867] Enable/disable mechanism for new profile field types
Adds methods to enable, disable and purge profile field types to the
profilefields\manager class. These methods are to be called from
extensions that add new profile field types on the enable, disable
and purge methods of the ext class. If not done, any profile field
of a new type that is left after extension is disabled or removed will
break the forum in several places.
PHPBB3-13867- phpBB/config/default/container/services_profilefield.yml (version 78ea30860800e5e58bf8d7b8cfbbcaf08193dece)
- phpBB/phpbb/profilefields/manager.php (version 78ea30860800e5e58bf8d7b8cfbbcaf08193dece)
