Build #447

Plan branch:

Build: #447 was successful Changes by Marc

Code commits

phpBB 3.3.x

  • Marc

    Marc 6e66f1505c8c3d205dd6d5b9df70a3beb3903851

    Merge pull request #6392 from lionel-rowe/ticket/8071
    [ticket/8071] Add sql_last_inserted_id alias for sql_nextid

  • Marc

    Marc b5c316c9c39b083970e065892ef6c3187e1d10f6 m

    [ticket/8071] Make nextid alias of sql_last_inserted_id and add deprecation
    PHPBB3-8071

    • phpBB/phpbb/db/driver/driver.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
    • phpBB/phpbb/db/driver/driver_interface.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
    • phpBB/phpbb/db/driver/factory.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
    • phpBB/phpbb/db/driver/mssql_odbc.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
    • phpBB/phpbb/db/driver/mssqlnative.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
    • phpBB/phpbb/db/driver/mysqli.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
    • phpBB/phpbb/db/driver/oracle.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
    • phpBB/phpbb/db/driver/postgres.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
    • phpBB/phpbb/db/driver/sqlite3.php (version b5c316c9c39b083970e065892ef6c3187e1d10f6)
  • lionel-rowe <lionel.rowe@gmail.com>

    lionel-rowe <lionel.rowe@gmail.com> 9fb98201f209c8976d43b8003aabdabadda03932 m

    [ticket/8071] Add sql_last_inserted_id alias for sql_nextid
    Fixes [DBAL function sql_nextid - name is
    misleading](PHPBB3-8071">https://tracker.phpbb.com/browse/PHPBB3-8071).

    Per the tracker issue:
    > This function gets the ID of the last inserted row, not the ID of the next row
    to be inserted (which is difficult due to different autoincrement steps and also
    lends itself nicely to race conditions).

    @iwisdom replied that the naming is consistent with how PHP itself names this
    functionality, but the link they posted doesn't support that (I guess this is
    referring to a much older version of PHP? The comment is from 2009).

    PHPBB3-8071

    • phpBB/phpbb/db/driver/driver_interface.php (version 9fb98201f209c8976d43b8003aabdabadda03932)
    • phpBB/phpbb/db/driver/factory.php (version 9fb98201f209c8976d43b8003aabdabadda03932)
    • phpBB/phpbb/db/driver/mssql_odbc.php (version 9fb98201f209c8976d43b8003aabdabadda03932)
    • phpBB/phpbb/db/driver/mssqlnative.php (version 9fb98201f209c8976d43b8003aabdabadda03932)
    • phpBB/phpbb/db/driver/mysqli.php (version 9fb98201f209c8976d43b8003aabdabadda03932)
    • phpBB/phpbb/db/driver/oracle.php (version 9fb98201f209c8976d43b8003aabdabadda03932)
    • phpBB/phpbb/db/driver/postgres.php (version 9fb98201f209c8976d43b8003aabdabadda03932)
    • phpBB/phpbb/db/driver/sqlite3.php (version 9fb98201f209c8976d43b8003aabdabadda03932)