Build: #353 was successful
Job: PHP 7.2 - SQLite Package was successful
Code commits
phpBB 3.3.x
-
Marc 8246023e0fc57d5ab1d429f668709895abf5b36e
Merge pull request #6313 from Nicofuma/ticket/16891
[ticket/16891] Do not change an extension status in the midle of a request -
Tristan Darricau <tristan.darricau@gmail.com> b28b94b1f1990b031c451d8658e111c7ec8fdcf7 m
[ticket/16891] Do not change an extension status in the middle of a request
When enabling an extension, it should be considered as not being enabled for
the entire request as if the "enabled" flag is switch during the request, the
extension will stay not loaded (same when disabling an extension).
Example when it can be an issue today : if the router is called for the first
time after enabling the extension and if the extension uses a custom route
loader (like phpbb/pages) then the router will fail because the custom route
will be found but the custom loader will not be loaded and available.
PHPBB3-16891- phpBB/config/default/container/services.yml (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)
- phpBB/phpbb/extension/manager.php (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)
- phpBB/phpbb/routing/router.php (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)
- tests/dbal/migrator_test.php (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)
- tests/extension/manager_test.php (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)
- tests/extension/metadata_manager_test.php (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)
- tests/mock/dummy_router.php (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)
- tests/mock/extension_manager.php (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)
- tests/test_framework/phpbb_functional_test_case.php (version b28b94b1f1990b031c451d8658e111c7ec8fdcf7)