phpBB Ascraeus

• 

  Joas Schilling 17 Nov 2014 4f96688bf7d8630b7977852665d4c6d04117f10a

  Merge pull request #3145 from bantu/ticket/13338
  [ticket/13338] Make all tests run on their own. Avoid _test suffix for abstract test case classes.
• 

  Joas Schilling 17 Nov 2014 f261c748b6214541373f955b990354c9b6cc0677

  Merge branch 'develop-olympus' into develop-ascraeus
• 

  Joas Schilling 17 Nov 2014 2b55476df072b706a790df407dffdd26f05b9a50

  Merge pull request #3147 from bantu/ticket/13341-ascraeus
  [ticket/13341] Change coverage to whitelist to prevent errors with temp files
• 

  Joas Schilling 17 Nov 2014 d4fd5e3365922deac9a72254a00461f1f74a9203 m

  Merge pull request #3146 from bantu/ticket/13341
  [ticket/13341] Change coverage to whitelist to prevent errors with temp ...
• 

  Andreas Fischer <bantu@phpbb.com> 17 Nov 2014 21c8985fe85d54facc9dce59f6b7cbd293b21ade

  [ticket/13338] Add include statements for dependencies.
  PHPBB3-13338

  • tests/console/cron/run_test.php (version 21c8985fe85d54facc9dce59f6b7cbd293b21ade)
  • tests/controller/controller_test.php (version 21c8985fe85d54facc9dce59f6b7cbd293b21ade)
  • tests/functions/validate_username_test.php (version 21c8985fe85d54facc9dce59f6b7cbd293b21ade)
  • tests/notification/group_request_test.php (version 21c8985fe85d54facc9dce59f6b7cbd293b21ade)
  • tests/test_framework/phpbb_session_test_case.php (version 21c8985fe85d54facc9dce59f6b7cbd293b21ade)
  • tests/tree/nestedset_forum_base.php (version 21c8985fe85d54facc9dce59f6b7cbd293b21ade)
• 

  Andreas Fischer <bantu@phpbb.com> 17 Nov 2014 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33

  [ticket/13338] Do not use the _test.php suffix for abstract test case classes.
  PHPBB3-13338

  • tests/functional/acp_groups_test.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/avatar_acp_groups_test.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/avatar_acp_users_test.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/avatar_ucp_groups_test.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/avatar_ucp_users_test.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/common_avatar_test.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/common_avatar_test_case.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/common_groups_test.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/common_groups_test_case.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
  • tests/functional/ucp_groups_test.php (version 765d72d1941cd8c9aafa3a8b75cfd0372ee9db33)
• 

  Andreas Fischer <bantu@phpbb.com> 17 Nov 2014 a918abe113fc85cad4d0e0778b815279b00062b9

  [ticket/13338] Move insert_config_array_test to functions_acp, add deps.
  PHPBB3-13338

  • tests/functions/insert_config_array_test.php (version a918abe113fc85cad4d0e0778b815279b00062b9)
  • tests/functions_acp/insert_config_array_test.php (version a918abe113fc85cad4d0e0778b815279b00062b9)
• 

  Andreas Fischer <bantu@phpbb.com> 14 Nov 2014 8297f700d0fdeb81843baa02f46bf3b42ce114b9 m

  Merge pull request #3146 from bantu/ticket/13341
  [ticket/13341] Change coverage to whitelist to prevent errors with temp ...
  
  * bantu/ticket/13341:
    [ticket/13341] Change coverage to whitelist to prevent errors with temp files.
  
  Conflicts:
          phpunit.xml.dist
• 

  Andreas Fischer <bantu@phpbb.com> 14 Nov 2014 c40d7f08962f3808146c6a8afa7709a0b01d22b5 m

  [ticket/13341] Change coverage to whitelist to prevent errors with temp files.
  b4f95deefc9d456c5a2d0f6338f6dcecc0829652 suggests that this can lead to issues
  with classes having the same name. However, this does not seem to be a problem
  with the current version of PHPUnit we are using.
  
  Despite https://phpunit.de/manual/4.1/en/code-coverage-analysis.html saying
  that addUncoveredFilesFromWhitelist="true" is optional, this seems to be on by
  default in PHPUnit 4.1.0. As a result, all files are considered for code
  coverage; which is what we want.
  
  processUncoveredFilesFromWhitelist is however false (by default) and as such
  even files that are considered for code coverage are not processed through PHP
  when not used in actual tests. Since it is already impossible to test multiple
  classes with the same name in the same test run (without process isolation),
  because that would already lead to "cannot redeclare class" errors, it is also
  impossible for "cannot redeclare class" errors to happen in test coverage.
  
  PHPBB3-13341

  • phpunit.xml.dist (version c40d7f08962f3808146c6a8afa7709a0b01d22b5)