Build #152

Plan branch:

Build: #152 failed Changes by nicofuma and Marc

Stages & jobs

  1. Default Stage

Code commits

phpBB Rhea

  • nicofuma

    nicofuma 3acee9a3eea8e3fdcef59876da273358a46903e8

    Merge pull request #4189 from marc1706/ticket/14492
    [ticket/14492] Improve send stats page and include VigLink

    * marc1706/ticket/14492: (47 commits)
      [ticket/14492] Add user service to installer & only instantiate if needed
      [ticket/14492] Fix redirection to help phpBB page
      [ticket/14492] Encode URI components in systemdata for stats
      [ticket/14492] Always update the time the stats were sent
      [ticket/14492] Update versions in files
      [ticket/14492] Add missing event variable
      [ticket/14492] Don't explicitly pass data providers by refs
      [ticket/14492] Update phpBB version and fix miscellaneous code issues
      [ticket/14492] Install all extensions if 'all' is specified for extensions
      [ticket/14492] Checkout master if viglink tag does not exist for latest version
      [ticket/14492] Add language variables for updating extensions
      [ticket/14492] Prevent timeouts in install & update extensions tasks
      [ticket/14492] Use same list for checking if extension should be updated
      [ticket/14492] Add missing config to schema_data.sql
      [ticket/14492] Unify version check for installing default extensions
      [ticket/14492] Use extension manager instead of finder and add try/catch
      [ticket/14492] Checkout viglink for each version depending on tags
      [ticket/14492] Remove unused use statement
      [ticket/14492] Redirect to help phpBB page after installation
      [ticket/14492] Properly retrieve version updating from
      ...

  • Marc

    Marc dee5e6e07636db7e35a82919a723907e734fbcd1

    [ticket/14492] Add language variables for updating extensions
    PHPBB3-14492

    • phpBB/language/en/acp/common.php (version dee5e6e07636db7e35a82919a723907e734fbcd1)
    • phpBB/language/en/cli.php (version dee5e6e07636db7e35a82919a723907e734fbcd1)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version dee5e6e07636db7e35a82919a723907e734fbcd1)
  • Marc

    Marc 9f3b151dabd9cfeefd40c89c79c9e57ca5354bae

    [ticket/14492] Checkout master if viglink tag does not exist for latest version
    PHPBB3-14492

    • build/build.xml (version 9f3b151dabd9cfeefd40c89c79c9e57ca5354bae)
  • Marc

    Marc 64f0d74489515ad76d0caf6cfdf100ef92e16328

    [ticket/14492] Properly retrieve version updating from
    PHPBB3-14492

    • phpBB/phpbb/install/module/update_database/task/update.php (version 64f0d74489515ad76d0caf6cfdf100ef92e16328)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version 64f0d74489515ad76d0caf6cfdf100ef92e16328)
  • Marc

    Marc e519b21b2e563f9d751aa8f9157ccc489b660ec8

    [ticket/14492] Only show fail of extension install if it's available
    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version e519b21b2e563f9d751aa8f9157ccc489b660ec8)
  • Marc

    Marc 88f197e67aab9e40e4688d6da7096dac59934101

    [ticket/14492] Checkout viglink for each version depending on tags
    PHPBB3-14492

    • build/build.xml (version 88f197e67aab9e40e4688d6da7096dac59934101)
  • Marc

    Marc 69dece6197d6289199a713e7db57cc80574aae69

    [ticket/14492] Removed unused use statement
    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version 69dece6197d6289199a713e7db57cc80574aae69)
  • Marc

    Marc b9c284d85be82e2a8f50c20e147d1ca2352453d4

    [ticket/14492] Update phpBB version and fix miscellaneous code issues
    PHPBB3-14492

    • build/build.xml (version b9c284d85be82e2a8f50c20e147d1ca2352453d4)
    • phpBB/includes/acp/acp_help_phpbb.php (version b9c284d85be82e2a8f50c20e147d1ca2352453d4)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version b9c284d85be82e2a8f50c20e147d1ca2352453d4)
  • Marc

    Marc 930b02342e4f27f1c72fe0590f7153298331c3a6

    [ticket/14492] Check if composer.json exists in viglink folder on file_check
    PHPBB3-14492

    • phpBB/phpbb/install/module/update_filesystem/task/file_check.php (version 930b02342e4f27f1c72fe0590f7153298331c3a6)
  • Marc

    Marc 4f0627de035e7539a78e05139cfb9a5e8d59163a

    [ticket/14492] Add missing config to schema_data.sql
    PHPBB3-14492

    • phpBB/install/schemas/schema_data.sql (version 4f0627de035e7539a78e05139cfb9a5e8d59163a)
  • Marc

    Marc ffe900c72d358ba0337c607f2ed76f893715f686

    [ticket/14492] Define extensions to install in config not via cli argument
    PHPBB3-14492

    • phpBB/docs/install-config.sample.yml (version ffe900c72d358ba0337c607f2ed76f893715f686)
    • phpBB/docs/update-config.sample.yml (version ffe900c72d358ba0337c607f2ed76f893715f686)
    • phpBB/language/en/install.php (version ffe900c72d358ba0337c607f2ed76f893715f686)
    • phpBB/phpbb/install/console/command/install/install.php (version ffe900c72d358ba0337c607f2ed76f893715f686)
    • phpBB/phpbb/install/console/command/update/update.php (version ffe900c72d358ba0337c607f2ed76f893715f686)
    • phpBB/phpbb/install/installer_configuration.php (version ffe900c72d358ba0337c607f2ed76f893715f686)
    • phpBB/phpbb/install/updater_configuration.php (version ffe900c72d358ba0337c607f2ed76f893715f686)
  • Marc

    Marc edfc4f3efc742342a37a5d510909aece6ae4c95d

    [ticket/14492] Use same list for checking if extension should be updated
    PHPBB3-14492

    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version edfc4f3efc742342a37a5d510909aece6ae4c95d)
    • phpBB/phpbb/install/module/update_filesystem/task/file_check.php (version edfc4f3efc742342a37a5d510909aece6ae4c95d)
  • Marc

    Marc eb1ade67681ee7c88845978eade07ad3ac96357a

    [ticket/14492] Set install extensions to synthetic and fix step count
    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version eb1ade67681ee7c88845978eade07ad3ac96357a)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version eb1ade67681ee7c88845978eade07ad3ac96357a)
    • tests/test_framework/phpbb_functional_test_case.php (version eb1ade67681ee7c88845978eade07ad3ac96357a)
  • Marc

    Marc 15f433f00fb84fa8afa97ae95372b7dc6826f5f5

    [ticket/14492] Always update the time the stats were sent
    PHPBB3-14492

    • phpBB/includes/acp/acp_help_phpbb.php (version 15f433f00fb84fa8afa97ae95372b7dc6826f5f5)
  • Marc

    Marc d62d35ad46baf9a7563a9f58038b16272cdf7c2d

    [ticket/14492] Redirect to help phpBB page after installation
    PHPBB3-14492

    • phpBB/phpbb/install/installer.php (version d62d35ad46baf9a7563a9f58038b16272cdf7c2d)
  • Marc

    Marc e308093d7507258855c14dcfb7214e81beac187e

    [ticket/14492] Use extension manager instead of finder and add try/catch
    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version e308093d7507258855c14dcfb7214e81beac187e)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version e308093d7507258855c14dcfb7214e81beac187e)
  • Marc

    Marc c54838b25f50dca71a2f516175621a7ccd39a071

    [ticket/14492] Update versions in files
    PHPBB3-14492

    • phpBB/docs/events.md (version c54838b25f50dca71a2f516175621a7ccd39a071)
    • phpBB/includes/acp/acp_help_phpbb.php (version c54838b25f50dca71a2f516175621a7ccd39a071)
    • phpBB/phpbb/db/migration/data/v320/add_help_phpbb.php (version c54838b25f50dca71a2f516175621a7ccd39a071)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version c54838b25f50dca71a2f516175621a7ccd39a071)
  • Marc

    Marc 1f270972084cd228e135481b766ada9941582155

    [ticket/14492] Install all extensions if 'all' is specified for extensions
    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version 1f270972084cd228e135481b766ada9941582155)
  • Marc

    Marc e02aca839921792d9074177ddbb2bde4dae35b3f

    [ticket/14492] Don't explicitly pass data providers by refs
    PHPBB3-14492

    • phpBB/includes/questionnaire/questionnaire.php (version e02aca839921792d9074177ddbb2bde4dae35b3f)
  • Marc

    Marc 67c3bd4a90c29a2b5c1250d3353faf823be48fad

    [ticket/14492] Remove incorrect changes to module order
    PHPBB3-14492

    • phpBB/config/installer/container/services_install_finish.yml (version 67c3bd4a90c29a2b5c1250d3353faf823be48fad)
    • phpBB/config/installer/container/services_update_database.yml (version 67c3bd4a90c29a2b5c1250d3353faf823be48fad)
  • Marc

    Marc afe16a62724451cb5c7eca7864a3c110404f4e2a

    [ticket/14492] Add missing event variable
    PHPBB3-14492

    • phpBB/adm/style/ajax.js (version afe16a62724451cb5c7eca7864a3c110404f4e2a)
  • Marc

    Marc 89fef2ce13a183c7b963032274f455a09a05f325

    [ticket/14492] Send statistics via ajax request
    Flooding ajax requests will try to be prevented and sending
    stats without JS will also properly work.

    PHPBB3-14492

    • phpBB/adm/style/acp_help_phpbb.html (version 89fef2ce13a183c7b963032274f455a09a05f325)
    • phpBB/adm/style/admin.js (version 89fef2ce13a183c7b963032274f455a09a05f325)
    • phpBB/adm/style/ajax.js (version 89fef2ce13a183c7b963032274f455a09a05f325)
    • phpBB/includes/acp/acp_help_phpbb.php (version 89fef2ce13a183c7b963032274f455a09a05f325)
    • phpBB/phpbb/db/migration/data/v320/add_help_phpbb.php (version 89fef2ce13a183c7b963032274f455a09a05f325)
  • Marc

    Marc 9b4190e1365aed639068d341cb4296e895ad4ba1

    [ticket/14492] Encode URI components in systemdata for stats
    The stats data needs to be URI encoded to prevent issues when
    submitting the data to the receive_stats script on www.phpbb.com.

    PHPBB3-14492

    • phpBB/adm/style/ajax.js (version 9b4190e1365aed639068d341cb4296e895ad4ba1)
  • Marc

    Marc b1596fda7f88bc0e2817a1143be6ff94ef3aae2a

    [ticket/14492] Prevent timeouts in install & update extensions tasks
    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version b1596fda7f88bc0e2817a1143be6ff94ef3aae2a)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version b1596fda7f88bc0e2817a1143be6ff94ef3aae2a)
  • Marc

    Marc 65d6e338a99baa2f100d6bd4dea5cd76ac146ac3

    [ticket/14492] Allow specifying extensions to update & install
    PHPBB3-14492

    • phpBB/language/en/install.php (version 65d6e338a99baa2f100d6bd4dea5cd76ac146ac3)
    • phpBB/phpbb/install/console/command/install/install.php (version 65d6e338a99baa2f100d6bd4dea5cd76ac146ac3)
    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version 65d6e338a99baa2f100d6bd4dea5cd76ac146ac3)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version 65d6e338a99baa2f100d6bd4dea5cd76ac146ac3)
  • Marc

    Marc fd37919ecb8e6e6618145aafae9de864fe16ded8

    [ticket/14492] Remove unused use statement
    PHPBB3-14492

    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version fd37919ecb8e6e6618145aafae9de864fe16ded8)
  • Marc

    Marc 8ded30bbbe1e12ed301c2deb43d52da5a22d5b05

    [ticket/14492] Fix redirection to help phpBB page
    PHPBB3-14492

    • phpBB/phpbb/install/installer.php (version 8ded30bbbe1e12ed301c2deb43d52da5a22d5b05)
  • Marc

    Marc 5895f56de05b637765a6583b8c51c1db3daabe91

    [ticket/14492] Add user service to installer & only instantiate if needed
    PHPBB3-14492

    • phpBB/config/installer/container/services.yml (version 5895f56de05b637765a6583b8c51c1db3daabe91)
    • phpBB/phpbb/install/installer.php (version 5895f56de05b637765a6583b8c51c1db3daabe91)
  • Marc

    Marc 2fa23c9b3f55e024f6a35c268cd7878e68ad08c2

    [ticket/14492] Unify version check for installing default extensions
    PHPBB3-14492

    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version 2fa23c9b3f55e024f6a35c268cd7878e68ad08c2)
  • Marc

    Marc f604e1ab5d5d780ff4bed1e39fa83cc264a8af71

    [ticket/14492] Rework logic for selecting which extensions to update
    PHPBB3-14492

    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version f604e1ab5d5d780ff4bed1e39fa83cc264a8af71)
  • Marc

    Marc c1035c98e455548fe14fbf5443bb98137d4e3d5d

    [ticket/14492] Rename files to  help_phpbb and fix css tabbing
    PHPBB3-14492

    • phpBB/adm/style/acp_help_phpbb.html (version c1035c98e455548fe14fbf5443bb98137d4e3d5d)
    • phpBB/adm/style/acp_send_statistics.html (version c1035c98e455548fe14fbf5443bb98137d4e3d5d)
    • phpBB/adm/style/admin.css (version c1035c98e455548fe14fbf5443bb98137d4e3d5d)
    • phpBB/includes/acp/acp_help_phpbb.php (version c1035c98e455548fe14fbf5443bb98137d4e3d5d)
    • phpBB/includes/acp/acp_send_statistics.php (version c1035c98e455548fe14fbf5443bb98137d4e3d5d)
    • phpBB/includes/acp/info/acp_help_phpbb.php (version c1035c98e455548fe14fbf5443bb98137d4e3d5d)
    • phpBB/includes/acp/info/acp_send_statistics.php (version c1035c98e455548fe14fbf5443bb98137d4e3d5d)
    • phpBB/phpbb/db/migration/data/v320/add_help_phpbb.php (version c1035c98e455548fe14fbf5443bb98137d4e3d5d)
  • Marc

    Marc ade5183ba1f10e3ba1aea927204e25f3b218ceb2

    [ticket/14492] Pass u_action to acp form and add stats config
    PHPBB3-14492

    • phpBB/includes/acp/acp_help_phpbb.php (version ade5183ba1f10e3ba1aea927204e25f3b218ceb2)
    • phpBB/install/schemas/schema_data.sql (version ade5183ba1f10e3ba1aea927204e25f3b218ceb2)
  • Marc

    Marc 80a63a9a94af042da37227ed747eba0feeac1049

    [ticket/14492] Add missing input name
    PHPBB3-14492

    • phpBB/adm/style/acp_help_phpbb.html (version 80a63a9a94af042da37227ed747eba0feeac1049)
  • Marc

    Marc c07ecb060dd04c76d8bd166a0a8a7226a8167f06

    [ticket/14492] Add events for modifying help phpBB page
    PHPBB3-14492

    • phpBB/adm/style/acp_help_phpbb.html (version c07ecb060dd04c76d8bd166a0a8a7226a8167f06)
    • phpBB/adm/style/admin.css (version c07ecb060dd04c76d8bd166a0a8a7226a8167f06)
    • phpBB/docs/events.md (version c07ecb060dd04c76d8bd166a0a8a7226a8167f06)
    • phpBB/includes/acp/acp_help_phpbb.php (version c07ecb060dd04c76d8bd166a0a8a7226a8167f06)
  • Marc

    Marc 90a5e22eb51fa20c94d576ffc5cdb49fb31dab3a

    [ticket/14492] Correctly check if extension was enabled during install
    Also fixed some incorrectly generated log messages and improved the
    regex.

    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version 90a5e22eb51fa20c94d576ffc5cdb49fb31dab3a)
  • Marc

    Marc 8fb2347cfa89ef9768311e92f11da4b090b94f7b

    [ticket/14492] Install all packaged extensions by default
    PHPBB3-14492

    • phpBB/config/installer/container/services_install_finish.yml (version 8fb2347cfa89ef9768311e92f11da4b090b94f7b)
    • phpBB/language/en/install.php (version 8fb2347cfa89ef9768311e92f11da4b090b94f7b)
    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version 8fb2347cfa89ef9768311e92f11da4b090b94f7b)
    • phpBB/phpbb/install/module/install_finish/task/install_viglink.php (version 8fb2347cfa89ef9768311e92f11da4b090b94f7b)
  • Marc

    Marc 4451db9f225d7a0e8a12503f0ff2f1393ee42467

    [ticket/14492] Apply fixes to update extensions task
    The regex was also simplified.

    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version 4451db9f225d7a0e8a12503f0ff2f1393ee42467)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version 4451db9f225d7a0e8a12503f0ff2f1393ee42467)
  • Marc

    Marc 36460ebdf679f3cecb11afdc6e43e64195cc1d27

    [ticket/14492] Do not copy viglink on update if it was deleted
    PHPBB3-14492

    • phpBB/phpbb/install/module/update_filesystem/task/file_check.php (version 36460ebdf679f3cecb11afdc6e43e64195cc1d27)
  • Marc

    Marc c5e0635bc79197011744394a221b5ccdcf305fc6

    [ticket/14492] Add basic layout for enabling viglink
    PHPBB3-14492

    • phpBB/adm/style/acp_send_statistics.html (version c5e0635bc79197011744394a221b5ccdcf305fc6)
    • phpBB/adm/style/admin.css (version c5e0635bc79197011744394a221b5ccdcf305fc6)
    • phpBB/adm/style/overall_header.html (version c5e0635bc79197011744394a221b5ccdcf305fc6)
    • phpBB/includes/functions_acp.php (version c5e0635bc79197011744394a221b5ccdcf305fc6)
    • phpBB/language/en/acp/common.php (version c5e0635bc79197011744394a221b5ccdcf305fc6)
  • Marc

    Marc cc7a0aa4fb2d6c8efd5c78df7d68328c9f8d4d32

    [ticket/14492] Use guzzle for submitting data to stats service
    PHPBB3-14492

    • phpBB/adm/style/acp_help_phpbb.html (version cc7a0aa4fb2d6c8efd5c78df7d68328c9f8d4d32)
    • phpBB/includes/acp/acp_help_phpbb.php (version cc7a0aa4fb2d6c8efd5c78df7d68328c9f8d4d32)
    • phpBB/language/en/acp/common.php (version cc7a0aa4fb2d6c8efd5c78df7d68328c9f8d4d32)
  • Marc

    Marc f9b46a4ae7d106cb765a762acf2e6a362e5b636d

    [ticket/14492] Remove not needed language entry
    PHPBB3-14492

    • phpBB/language/en/acp/common.php (version f9b46a4ae7d106cb765a762acf2e6a362e5b636d)
  • Marc

    Marc 6f315da9ab3eaa8e680414eeed6d763a9e2102b6

    [ticket/14492] Improve look and display data again
    PHPBB3-14492

    • phpBB/adm/style/acp_send_statistics.html (version 6f315da9ab3eaa8e680414eeed6d763a9e2102b6)
    • phpBB/adm/style/admin.css (version 6f315da9ab3eaa8e680414eeed6d763a9e2102b6)
    • phpBB/adm/style/admin.js (version 6f315da9ab3eaa8e680414eeed6d763a9e2102b6)
  • Marc

    Marc 9525a64d6411cea7c72b140e8266678593148038

    [ticket/14492] Start working on the build script
    PHPBB3-14492

    • build/build.xml (version 9525a64d6411cea7c72b140e8266678593148038)
  • Marc

    Marc 267d1b15c4884dd67a299b2428251e68cd55327b

    [ticket/14492] Re-enable extensions if updated during update
    PHPBB3-14492

    • phpBB/config/installer/container/services_install_finish.yml (version 267d1b15c4884dd67a299b2428251e68cd55327b)
    • phpBB/config/installer/container/services_update_database.yml (version 267d1b15c4884dd67a299b2428251e68cd55327b)
    • phpBB/language/en/install.php (version 267d1b15c4884dd67a299b2428251e68cd55327b)
    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version 267d1b15c4884dd67a299b2428251e68cd55327b)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version 267d1b15c4884dd67a299b2428251e68cd55327b)
  • Marc

    Marc c30394ff4a1034e5e6e7a0862e9101b5a80d8587

    [ticket/14492] Add basic task for installing viglink extension
    PHPBB3-14492

    • phpBB/config/installer/container/services_install_finish.yml (version c30394ff4a1034e5e6e7a0862e9101b5a80d8587)
    • phpBB/language/en/install.php (version c30394ff4a1034e5e6e7a0862e9101b5a80d8587)
    • phpBB/phpbb/install/module/install_finish/task/install_viglink.php (version c30394ff4a1034e5e6e7a0862e9101b5a80d8587)
  • Marc

    Marc cba4f4f568028d2eb019ddde0eded62799e1b377

    [ticket/14492] Use new guzzlehttp client
    PHPBB3-14492

    • phpBB/includes/acp/acp_help_phpbb.php (version cba4f4f568028d2eb019ddde0eded62799e1b377)
  • Marc

    Marc 9fb2a5d5f8ed4c23689843178a4a06a151d146e6

    [ticket/14492] Update language variables and trigger details text
    PHPBB3-14492

    • phpBB/adm/style/acp_help_phpbb.html (version 9fb2a5d5f8ed4c23689843178a4a06a151d146e6)
    • phpBB/includes/acp/acp_help_phpbb.php (version 9fb2a5d5f8ed4c23689843178a4a06a151d146e6)
    • phpBB/includes/acp/info/acp_help_phpbb.php (version 9fb2a5d5f8ed4c23689843178a4a06a151d146e6)
    • phpBB/language/en/acp/common.php (version 9fb2a5d5f8ed4c23689843178a4a06a151d146e6)
  • Marc

    Marc 430ec6f61d5da5b278ee2cadda535fcf9dcaed22

    [ticket/14492] Do not install extensions in installer if in test env
    PHPBB3-14492

    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version 430ec6f61d5da5b278ee2cadda535fcf9dcaed22)