Build #1,054

Plan branch:

Build: #1054 was successful Changes by Máté Bartus <CHItA@users.noreply.github.com>

Code commits

phpBB Master

  • Máté Bartus <CHItA@users.noreply.github.com>

    Máté Bartus <CHItA@users.noreply.github.com> e92b5caf66113dac9fd969aed9004d7e7a62c8e1

    Merge pull request #6273 from CHItA/ticket/16741
    [ticket/16741] Database tools to use Doctrine

  • Marc

    Marc 66ecc0c19cac05b0afc14d43145a9c68a91ea9b3 m

    [ticket/16741] Split of callable into schema_perform_changes()
    PHPBB3-16741

    • phpBB/phpbb/db/tools/doctrine.php (version 66ecc0c19cac05b0afc14d43145a9c68a91ea9b3)
  • Marc

    Marc 81cddb2bc6ec04e11a671b6a3cfd849e026b2646 m

    [ticket/16741] Clean up functions, add missing docblocks and return type hints
    PHPBB3-16741

    • phpBB/phpbb/db/doctrine/comparator.php (version 81cddb2bc6ec04e11a671b6a3cfd849e026b2646)
    • phpBB/phpbb/db/doctrine/postgresql_platform.php (version 81cddb2bc6ec04e11a671b6a3cfd849e026b2646)
    • phpBB/phpbb/db/doctrine/table_helper.php (version 81cddb2bc6ec04e11a671b6a3cfd849e026b2646)
    • phpBB/phpbb/db/tools/doctrine.php (version 81cddb2bc6ec04e11a671b6a3cfd849e026b2646)
  • Marc

    Marc 5e6065ff9ee46d8ceab9aa235a2adfc897a68319 m

    [ticket/16741] Replace deprecated functions
    PHPBB3-16741

    • phpBB/phpbb/db/doctrine/case_insensitive_string.php (version 5e6065ff9ee46d8ceab9aa235a2adfc897a68319)
    • phpBB/phpbb/db/doctrine/postgresql_platform.php (version 5e6065ff9ee46d8ceab9aa235a2adfc897a68319)
    • phpBB/phpbb/db/doctrine/sqlsrv_platform.php (version 5e6065ff9ee46d8ceab9aa235a2adfc897a68319)
  • Marc

    Marc 78528d2b3210ccacae2dcd514c35db8899841375 m

    [ticket/16741] Add support for dropping primary keys and removing constraints
    PHPBB3-16741

    • phpBB/phpbb/db/doctrine/sqlsrv_platform.php (version 78528d2b3210ccacae2dcd514c35db8899841375)
    • phpBB/phpbb/db/tools/doctrine.php (version 78528d2b3210ccacae2dcd514c35db8899841375)
  • CHItA

    CHItA d4b8a48f11185ca981cf6978484af1f4dea3932a m

    [ticket/16741] Fix tests
    PHPBB3-16741

    • phpBB/phpbb/db/doctrine/sqlsrv_platform.php (version d4b8a48f11185ca981cf6978484af1f4dea3932a)
  • CHItA

    CHItA 59ca29232abcbe8dc2baefda3e84203c204ea083 m

    [ticket/16741] Fix coding style issues
    PHPBB3-16741

    • phpBB/phpbb/db/doctrine/oracle_platform.php (version 59ca29232abcbe8dc2baefda3e84203c204ea083)
    • phpBB/phpbb/db/doctrine/sqlsrv_platform.php (version 59ca29232abcbe8dc2baefda3e84203c204ea083)
  • CHItA

    CHItA a663a6c3948515705c57635fb895778a99755c6e m

    [ticket/16741] Debug SQLServer Tests
    PHPBB3-16741

    • phpBB/phpbb/db/tools/doctrine.php (version a663a6c3948515705c57635fb895778a99755c6e)
  • CHItA

    CHItA e93c914da35a7ec8e69ea8fb0c393ef08313e88e m

    [ticket/16741] Fix tests
    PHPBB3-16741

    • phpBB/phpbb/di/container_builder.php (version e93c914da35a7ec8e69ea8fb0c393ef08313e88e)
    • tests/dbal/db_tools_test.php (version e93c914da35a7ec8e69ea8fb0c393ef08313e88e)
  • CHItA

    CHItA a0584b8677a1928286c8c29528a8cbfb43f041ae m

    [ticket/16741] Code review fixes
    PHPBB3-16741

    • phpBB/config/default/container/services_db.yml (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/comparator.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/connection_factory.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/oci8/connection.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/oci8/driver.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/oci8/result.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/oci8/schema_manager.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/oci8/statement.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/oracle_platform.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/postgresql_platform.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/sqlsrv_platform.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/doctrine/table_helper.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/tools/doctrine.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/tools/tools.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/db/tools/tools_interface.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • phpBB/phpbb/di/container_builder.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
    • tests/dbal/db_tools_test.php (version a0584b8677a1928286c8c29528a8cbfb43f041ae)
  • Tristan Darricau <tristan.darricau@gmail.com>

    Tristan Darricau <tristan.darricau@gmail.com> b8d555f56a52664f3b87016cfa0c2ff9147602b5 m

    [ticket/16741] Specific DBs fixes
    MSSQL:
    - Fix bool type
    - Fix comparator
    - Drop Default constraint before deleting column
    - Rename Default constraint to use phpBB's names
    - Re-create the indices when changing the type of one column
    - Uses varchar instead of varbinary

    PostgreSQL:
    - Creates auto increment sequences by hand instead of using serial
      in order to use phpBB's names
    - Drop constraint on unique / primary indices

    Oracle:
    - Rename indices to use phpBB's names
    - Fix string not null behaviour
    - Fix broken regex in Oracle driver
    - Handle to long indices on Oracle
    - Rename auto_increment trigger and sequence
    - Automatically lowercase keys in assoc results

    PHPBB3-16741

    • phpBB/config/default/container/services_db.yml (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/install/convert/controller/convertor.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/comparator.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/oci8/connection.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/oci8/driver.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/oci8/result.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/oci8/schema_manager.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/oci8/statement.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/oracle_platform.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/postgresql_platform.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/doctrine/sqlsrv_platform.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/driver/oracle.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/tools/mssql.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
    • phpBB/phpbb/db/tools/postgres.php (version b8d555f56a52664f3b87016cfa0c2ff9147602b5)
  • Tristan Darricau <tristan.darricau@gmail.com>

    Tristan Darricau <tristan.darricau@gmail.com> b266ebbceff5806bc7eb9e1c135856855f3a0acf m

    [ticket/16741] Test fixes
    PHPBB3-16741

    • phpBB/phpbb/profilefields/manager.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/captcha/qa_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/dbal/auto_increment_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/dbal/db_tools_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/dbal/migrator_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/extension/manager_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/extension/metadata_manager_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/migrations/migrations_check_config_added_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/migrator/convert_timezones_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/migrator/get_callable_from_step_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/migrator/schema_generator_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/mock/config_php_file.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/notification/convert_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/profilefields/manager_test.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/test_framework/phpbb_database_test_case.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/test_framework/phpbb_database_test_connection_manager.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
    • tests/test_framework/phpbb_functional_test_case.php (version b266ebbceff5806bc7eb9e1c135856855f3a0acf)
  • Tristan Darricau <tristan.darricau@gmail.com>

    Tristan Darricau <tristan.darricau@gmail.com> 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3 m

    [ticket/16741] General fixes
    PHPBB3-16741

    • phpBB/config/default/container/services.yml (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/config/default/container/services_db.yml (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/config/default/container/services_doctrine.yml (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/develop/create_schema_files.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/includes/functions_compatibility.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/install/convert/controller/convertor.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/install/convertors/functions_phpbb20.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/doctrine/connection_factory.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/doctrine/connection_parameter_factory.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/doctrine/table_helper.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/doctrine/type_converter.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/migration/data/v310/timezone.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/tools/doctrine.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/tools/factory.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/tools/tools.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/db/tools/tools_interface.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/di/container_builder.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/install/helper/database.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/install/module/install_database/task/add_tables.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
    • phpBB/phpbb/install/module/install_database/task/create_schema_file.php (version 6ce708539b9cd92f0f3c9cd37e4588ce2a567bb3)
  • CHItA

    CHItA 300e5399f5ca35f34ed75234c97426e1e68cc9e0 m

    [ticket/16741] Fix coding style issue
    PHPBB3-16741

    • phpBB/phpbb/db/doctrine/table_helper.php (version 300e5399f5ca35f34ed75234c97426e1e68cc9e0)
  • CHItA

    CHItA 522a17199deefe83949f317d980be468b7af9cb8 m

    [ticket/16741] Fix code sniffer
    PHPBB3-16741

    • build/code_sniffer/phpbb/Sniffs/Namespaces/UnusedUseSniff.php (version 522a17199deefe83949f317d980be468b7af9cb8)
  • CHItA

    CHItA 98134abe206de61b40ba8e64bd759cbfe4a48c9d m

    [ticket/16741] Database tools to use Doctrine
    PHPBB3-16741

    • phpBB/config/default/container/services.yml (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/config/default/container/services_doctrine.yml (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/doctrine/case_insensitive_string.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/doctrine/connection_factory.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/doctrine/connection_parameter_factory.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/doctrine/driver_convertor.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/doctrine/oracle_platform.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/doctrine/table_helper.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/doctrine/type_converter.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/tools/doctrine.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/tools/factory.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/tools/mssql.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/tools/postgres.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/tools/tools.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)
    • phpBB/phpbb/db/tools/tools_interface.php (version 98134abe206de61b40ba8e64bd759cbfe4a48c9d)