Build #1,272

Plan branch:

Build: #1272 was successful Changes by Marc

Stages & jobs

  1. Default Stage

Code commits

phpBB Master

  • Marc

    Marc 272daae33724e2bad3efd88441559c1a13d29870

    Merge pull request #6533 from rxu/ticket/17151-2
    [ticket/17151] Make settings forms use macros

  • rxu

    rxu 03e2222dd70c28bcf38bec42f8e383d8d862b94a m

    [ticket/17151] Add core.build_config_template event @changed information
    The event location's function has been renamed
    from build_config_template() to phpbb_build_cfg_template().

    PHPBB3-17151

    • phpBB/includes/functions_acp.php (version 03e2222dd70c28bcf38bec42f8e383d8d862b94a)
  • rxu

    rxu a1f236d85e9b02c4e9212ab8fb6c3430cfdf2ca9 m

    [ticket/17151] Fix board disable access setting
    PHPBB3-17151

    • phpBB/includes/acp/acp_board.php (version a1f236d85e9b02c4e9212ab8fb6c3430cfdf2ca9)
  • rxu

    rxu 3597c15100890a671797e15db90767601915ecad m

    [ticket/17151] Adjust code styling
    PHPBB3-17151

    • phpBB/includes/acp/acp_attachments.php (version 3597c15100890a671797e15db90767601915ecad)
    • phpBB/includes/acp/acp_board.php (version 3597c15100890a671797e15db90767601915ecad)
    • phpBB/includes/functions_acp.php (version 3597c15100890a671797e15db90767601915ecad)
    • phpBB/includes/ucp/ucp_prefs.php (version 3597c15100890a671797e15db90767601915ecad)
    • tests/functional/fixtures/ext/foo/bar/acp/main_module.php (version 3597c15100890a671797e15db90767601915ecad)
    • tests/functions_acp/build_cfg_template_test.php (version 3597c15100890a671797e15db90767601915ecad)
  • rxu

    rxu 463848dc08dc768f5b8380d11bc2b707b20369eb m

    [ticket/17151] Make textarea id optional
    PHPBB3-17151

    • phpBB/styles/all/template/macros/forms/input.twig (version 463848dc08dc768f5b8380d11bc2b707b20369eb)
    • phpBB/styles/all/template/macros/forms/select.twig (version 463848dc08dc768f5b8380d11bc2b707b20369eb)
    • phpBB/styles/all/template/macros/forms/textarea.twig (version 463848dc08dc768f5b8380d11bc2b707b20369eb)
  • rxu

    rxu f28d33726eba767c26b0d3d0b53d87a13b2f0dce m

    [ticket/17151] Extend forms tests
    PHPBB3-17151

    • tests/functional/extension_module_test.php (version f28d33726eba767c26b0d3d0b53d87a13b2f0dce)
    • tests/functional/fixtures/ext/foo/bar/acp/main_module.php (version f28d33726eba767c26b0d3d0b53d87a13b2f0dce)
  • rxu

    rxu 6349d3c1260125b972f474ccb9af4eca102c3ba6 m

    [ticket/17151] Reimplement radio buttons yes_no / enabled_disabled shorthands
    PHPBB3-17151

    • phpBB/includes/functions_acp.php (version 6349d3c1260125b972f474ccb9af4eca102c3ba6)
    • tests/functional/extension_module_test.php (version 6349d3c1260125b972f474ccb9af4eca102c3ba6)
    • tests/functional/fixtures/ext/foo/bar/acp/main_module.php (version 6349d3c1260125b972f474ccb9af4eca102c3ba6)
  • rxu

    rxu b6572652df63c670db46bbebc0a0294fadea4e0a m

    [ticket/17151] Revert radio yes_no/enabled_disabled, fix select "selected"
    PHPBB3-17151

    • phpBB/includes/acp/acp_attachments.php (version b6572652df63c670db46bbebc0a0294fadea4e0a)
    • phpBB/includes/acp/acp_board.php (version b6572652df63c670db46bbebc0a0294fadea4e0a)
    • phpBB/phpbb/avatar/manager.php (version b6572652df63c670db46bbebc0a0294fadea4e0a)
    • tests/avatar/manager_test.php (version b6572652df63c670db46bbebc0a0294fadea4e0a)
    • tests/functions_acp/build_cfg_template_test.php (version b6572652df63c670db46bbebc0a0294fadea4e0a)
  • rxu

    rxu 2d0969e3e12f513c00501f9f3a5e5cfe419770e9 m

    [ticket/17151] Fix avatar ACP options
    PHPBB3-17151

    • phpBB/phpbb/avatar/manager.php (version 2d0969e3e12f513c00501f9f3a5e5cfe419770e9)
    • tests/avatar/manager_test.php (version 2d0969e3e12f513c00501f9f3a5e5cfe419770e9)
  • rxu

    rxu 9401a59cfc562e7196d4529f9d6a82b43172ce29 m

    [ticket/17151] Refactor radio buttons output logic
    PHPBB3-17151

    • phpBB/includes/acp/acp_attachments.php (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
    • phpBB/includes/acp/acp_board.php (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
    • phpBB/includes/functions_acp.php (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
    • phpBB/phpbb/template/twig/extension/forms.php (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
    • phpBB/styles/all/template/macros/forms/input.twig (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
    • phpBB/styles/all/template/macros/forms/radio_buttons.twig (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
    • tests/functional/fixtures/ext/foo/bar/acp/main_module.php (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
    • tests/functions_acp/build_cfg_template_test.php (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
    • tests/functions_acp/h_radio_test.php (version 9401a59cfc562e7196d4529f9d6a82b43172ce29)
  • rxu

    rxu 830c1f3dc3e7375ad9b95833d59e110c203d0e51 m

    [ticket/17151] Adjust template output formatting
    PHPBB3-17151

    • phpBB/styles/all/template/macros/forms/input.twig (version 830c1f3dc3e7375ad9b95833d59e110c203d0e51)
    • phpBB/styles/all/template/macros/forms/select.twig (version 830c1f3dc3e7375ad9b95833d59e110c203d0e51)
  • rxu

    rxu 1cbe1d86da92ab652fc5a716a5d41486888b8d17 m

    [ticket/17151] Improve radio input type handling
    - allow more than 2 buttons count
    - allow custom buttons order
    - allow custom button labels

    Implemented by allowing JSON data format, backward compatibility preserved.

    PHPBB3-17151

    • phpBB/includes/functions_acp.php (version 1cbe1d86da92ab652fc5a716a5d41486888b8d17)
    • phpBB/phpbb/template/twig/extension/forms.php (version 1cbe1d86da92ab652fc5a716a5d41486888b8d17)
    • phpBB/styles/all/template/macros/forms/radio_buttons.twig (version 1cbe1d86da92ab652fc5a716a5d41486888b8d17)
    • tests/functional/extension_module_test.php (version 1cbe1d86da92ab652fc5a716a5d41486888b8d17)
    • tests/functional/fixtures/ext/foo/bar/acp/main_module.php (version 1cbe1d86da92ab652fc5a716a5d41486888b8d17)
  • rxu

    rxu 130366edfa7a1565007ff41e45a9e19ea37747e0 m

    [ticket/17151] Fix PHP warning on board settings page, add ACP pages test
    PHPBB3-17151

    • phpBB/includes/acp/acp_board.php (version 130366edfa7a1565007ff41e45a9e19ea37747e0)
    • tests/functional/acp_main_test.php (version 130366edfa7a1565007ff41e45a9e19ea37747e0)
  • rxu

    rxu 52517a5efde8805328fc20f7a2c0964b3dae6888 m

    [ticket/17151] Fix registration test error
    PHPBB3-17151

    • phpBB/adm/style/acp_bots.html (version 52517a5efde8805328fc20f7a2c0964b3dae6888)
    • phpBB/adm/style/acp_users_prefs.html (version 52517a5efde8805328fc20f7a2c0964b3dae6888)
    • phpBB/includes/acp/acp_board.php (version 52517a5efde8805328fc20f7a2c0964b3dae6888)
    • phpBB/includes/acp/acp_bots.php (version 52517a5efde8805328fc20f7a2c0964b3dae6888)
    • phpBB/includes/acp/acp_users.php (version 52517a5efde8805328fc20f7a2c0964b3dae6888)
    • phpBB/includes/functions.php (version 52517a5efde8805328fc20f7a2c0964b3dae6888)
    • phpBB/includes/ucp/ucp_prefs.php (version 52517a5efde8805328fc20f7a2c0964b3dae6888)
  • rxu

    rxu 7b04e411b62423ea4c640331b2805786c069f03b m

    [ticket/17151] Fix tests
    PHPBB3-17151

    • phpBB/includes/acp/acp_board.php (version 7b04e411b62423ea4c640331b2805786c069f03b)
    • phpBB/styles/all/template/macros/forms/select.twig (version 7b04e411b62423ea4c640331b2805786c069f03b)
    • tests/acp_board/select_auth_method_test.php (version 7b04e411b62423ea4c640331b2805786c069f03b)
    • tests/functional/fixtures/ext/foo/bar/acp/main_module.php (version 7b04e411b62423ea4c640331b2805786c069f03b)
    • tests/functions/style_select_test.php (version 7b04e411b62423ea4c640331b2805786c069f03b)
    • tests/functions_acp/build_cfg_template_test.php (version 7b04e411b62423ea4c640331b2805786c069f03b)
  • rxu

    rxu 7f365855ce3a848f365647f0a239bc40a8f28f5d m

    [ticket/17151] Deduplicate code for building configuration options data
    PHPBB3-17151

    • phpBB/includes/functions_acp.php (version 7f365855ce3a848f365647f0a239bc40a8f28f5d)
  • rxu

    rxu 9350e82d71f19ce29a63f3eec7c5e9c5365086a7 m

    [ticket/17151] Fix test error
    PHPBB3-17151

    • tests/functions_acp/build_cfg_template_test.php (version 9350e82d71f19ce29a63f3eec7c5e9c5365086a7)
  • rxu

    rxu 72770937f216f8e6bbf168ec3647b45b1e32b342 m

    [ticket/17151] Make settings forms use macros
    PHPBB3-17151

    • phpBB/includes/acp/acp_board.php (version 72770937f216f8e6bbf168ec3647b45b1e32b342)
    • phpBB/includes/functions.php (version 72770937f216f8e6bbf168ec3647b45b1e32b342)
    • phpBB/includes/functions_acp.php (version 72770937f216f8e6bbf168ec3647b45b1e32b342)
    • phpBB/phpbb/template/twig/extension/forms.php (version 72770937f216f8e6bbf168ec3647b45b1e32b342)
    • phpBB/styles/all/template/macros/forms/select.twig (version 72770937f216f8e6bbf168ec3647b45b1e32b342)
    • phpBB/styles/all/template/macros/forms/textarea.twig (version 72770937f216f8e6bbf168ec3647b45b1e32b342)
    • phpBB/styles/prosilver/template/ucp_prefs_personal.html (version 72770937f216f8e6bbf168ec3647b45b1e32b342)