Build #1,274

Plan branch:

Build: #1274 was successful Changes by Marc

Stages & jobs

  1. Default Stage

Code commits

phpBB Master

  • Marc

    Marc e813bcc7a56b937390999025c25fb20830982bdd

    Merge pull request #6632 from iMattPro/ticket/17333
    [ticket/17333] UX Enhancements for Web Push Subscribing

  • Marc

    Marc 02763dfadc5fce0391e68faaff3dfb4233412246

    Merge pull request #6634 from marc1706/ticket/17330
    [ticket/17330] Handle mozilla not properly handling webpush padding

  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> ca918f893e135b36f226a79e07db0dd36bb277d4 m

    [ticket/17333]  Suggested code improvements
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/includes/acp/acp_board.php (version ca918f893e135b36f226a79e07db0dd36bb277d4)
    • phpBB/includes/functions.php (version ca918f893e135b36f226a79e07db0dd36bb277d4)
    • phpBB/install/schemas/schema_data.sql (version ca918f893e135b36f226a79e07db0dd36bb277d4)
    • phpBB/language/en/acp/board.php (version ca918f893e135b36f226a79e07db0dd36bb277d4)
    • phpBB/phpbb/db/migration/data/v400/add_webpush_options.php (version ca918f893e135b36f226a79e07db0dd36bb277d4)
    • phpBB/phpbb/notification/method/webpush.php (version ca918f893e135b36f226a79e07db0dd36bb277d4)
    • tests/functional/notification_webpush_test.php (version ca918f893e135b36f226a79e07db0dd36bb277d4)
  • Marc

    Marc 35436f078c05fc6714cdf075172df6b4f1d0eea3 m

    [ticket/17330] Add try/catch block though it's not really needed
    PHPBB-17330

    • phpBB/phpbb/notification/method/webpush.php (version 35436f078c05fc6714cdf075172df6b4f1d0eea3)
  • Marc

    Marc e813bd02c608e6aacc5a4a0279930129896271d6 m

    [ticket/17330] Add test for set_endpoint_padding
    PHPBB-17330

    • tests/notification/notification_method_webpush_test.php (version e813bd02c608e6aacc5a4a0279930129896271d6)
  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> 36527a97b8ddc60b0dffea4d1ad53bc47a0afb1f m

    [ticket/17333] Optimize loading web push data only when needed
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/includes/functions.php (version 36527a97b8ddc60b0dffea4d1ad53bc47a0afb1f)
  • Marc

    Marc a90c59a8a17fc545082e0cf1ddba563344c95551 m

    [ticket/17330] Handle mozilla not properly handling webpush padding
    PHPBB-17330

    • phpBB/phpbb/notification/method/webpush.php (version a90c59a8a17fc545082e0cf1ddba563344c95551)
  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> 73e0412c88b38cd4a47b30202d93f3de41db9059 m

    [ticket/17333] Prevent double loading web push template data
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/includes/functions.php (version 73e0412c88b38cd4a47b30202d93f3de41db9059)
  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> 0ca85246331043bdf031ec7d8b9340b19c91abbb m

    [ticket/17333] Fix Subscribe text button color
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/styles/prosilver/theme/colours.css (version 0ca85246331043bdf031ec7d8b9340b19c91abbb)
  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> 5c58fd2055c2cb137af9f1759712fbff2eff81e9 m

    [ticket/17333] Add tests and fixes
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/phpbb/notification/method/webpush.php (version 5c58fd2055c2cb137af9f1759712fbff2eff81e9)
    • tests/functional/notification_webpush_test.php (version 5c58fd2055c2cb137af9f1759712fbff2eff81e9)
  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> e162b67c48b0a84d8f388f5e705ffb95191554f3 m

    [ticket/17333] Fix toggle icon colors
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/styles/prosilver/template/notification_dropdown.html (version e162b67c48b0a84d8f388f5e705ffb95191554f3)
  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> 4afba5c9feec00a375a0ab86f05bc8aa0ba620ce m

    [ticket/17333] Enable new configs by default
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/install/schemas/schema_data.sql (version 4afba5c9feec00a375a0ab86f05bc8aa0ba620ce)
    • phpBB/phpbb/db/migration/data/v400/add_webpush_options.php (version 4afba5c9feec00a375a0ab86f05bc8aa0ba620ce)
  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> d55ec608eceabe0b028ac33082545b2d205ff5a8 m

    [ticket/17333] Add push subscribe toggle to notification dropdown
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/includes/acp/acp_board.php (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/includes/functions.php (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/install/schemas/schema_data.sql (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/language/en/acp/board.php (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/language/en/common.php (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/phpbb/db/migration/data/v400/add_webpush_options.php (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/phpbb/notification/method/webpush.php (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/styles/prosilver/template/notification_dropdown.html (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/styles/prosilver/template/overall_header.html (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/styles/prosilver/template/ucp_notifications_options.html (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/styles/prosilver/theme/buttons.css (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
    • phpBB/styles/prosilver/theme/common.css (version d55ec608eceabe0b028ac33082545b2d205ff5a8)
  • Matt Friedman <maf675@gmail.com>

    Matt Friedman <maf675@gmail.com> e35a6f7aa5616e9d3ffe46c22c10bda0f4d3bfb5 m

    [ticket/17333] ACP option to enable-disable all push notifications
    PHPBB-17333

    Signed-off-by: Matt Friedman <maf675@gmail.com>

    • phpBB/includes/acp/acp_board.php (version e35a6f7aa5616e9d3ffe46c22c10bda0f4d3bfb5)
    • phpBB/install/schemas/schema_data.sql (version e35a6f7aa5616e9d3ffe46c22c10bda0f4d3bfb5)
    • phpBB/language/en/acp/board.php (version e35a6f7aa5616e9d3ffe46c22c10bda0f4d3bfb5)
    • phpBB/phpbb/db/migration/data/v400/add_webpush_options.php (version e35a6f7aa5616e9d3ffe46c22c10bda0f4d3bfb5)
    • phpBB/phpbb/notification/method/webpush.php (version e35a6f7aa5616e9d3ffe46c22c10bda0f4d3bfb5)