Build #1,359

Plan branch:

Build: #1359 was successful Changes by Marc

Stages & jobs

  1. Default Stage

Code commits

phpBB Master

  • Marc

    Marc 4985a27dcf573b5919bdb01d358781c58064900e

    Merge pull request #6737 from marc1706/feature/captcha_v2
    [feature/captcha_v2] Refactor captcha classes and implement turnstile captcha

  • Marc

    Marc dd49bb4a0a6835f207f91875024185782304d057 m

    [ticket/17414] Remove idempotency and use user ip for check
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/turnstile.php (version dd49bb4a0a6835f207f91875024185782304d057)
  • Marc

    Marc 3b27b65c760c4a16ea542c943a9211693ac1b222 m

    [ticket/17414] Change incomplete CAPTCHA to extend new base class
    PHPBB-17414

    • phpBB/config/default/container/services_captcha.yml (version 3b27b65c760c4a16ea542c943a9211693ac1b222)
    • phpBB/phpbb/captcha/plugins/base.php (version 3b27b65c760c4a16ea542c943a9211693ac1b222)
    • phpBB/phpbb/captcha/plugins/incomplete.php (version 3b27b65c760c4a16ea542c943a9211693ac1b222)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 3b27b65c760c4a16ea542c943a9211693ac1b222)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 3b27b65c760c4a16ea542c943a9211693ac1b222)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 3b27b65c760c4a16ea542c943a9211693ac1b222)
    • tests/captcha/incomplete_test.php (version 3b27b65c760c4a16ea542c943a9211693ac1b222)
  • Marc

    Marc fd994f4742f095020657cc9bba15640fc7bde63f m

    [ticket/17414] Add unit test for legacy wrapper
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version fd994f4742f095020657cc9bba15640fc7bde63f)
    • tests/captcha/legacy_wrapper_test.php (version fd994f4742f095020657cc9bba15640fc7bde63f)
  • Marc

    Marc 08ab64a3b20e6f9cd211d03ce9d87f4d3b2eda5d m

    [ticket/17414] Improve docblocks in legacy wrapper
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 08ab64a3b20e6f9cd211d03ce9d87f4d3b2eda5d)
  • Marc

    Marc fa66bc5150cdaa29d6556d7d81a78e7d8ce90a3a m

    [ticket/17414] Fix small issues with compatibility to legacy captchas
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version fa66bc5150cdaa29d6556d7d81a78e7d8ce90a3a)
    • phpBB/phpbb/captcha/plugins/qa.php (version fa66bc5150cdaa29d6556d7d81a78e7d8ce90a3a)
  • Marc

    Marc 28f597e1826bec448a93b59a53ca3e219e176a4a m

    [ticket/17413] Use lang function in turnstile captcha
    PHPBB-17413

    • phpBB/styles/prosilver/template/captcha_turnstile.html (version 28f597e1826bec448a93b59a53ca3e219e176a4a)
  • Marc

    Marc 687448be49a6d3a7d0ede2aeb42ab2d4b639999e m

    [ticket/17414] Clean up small code issues noticed by sniffer
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/base.php (version 687448be49a6d3a7d0ede2aeb42ab2d4b639999e)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 687448be49a6d3a7d0ede2aeb42ab2d4b639999e)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 687448be49a6d3a7d0ede2aeb42ab2d4b639999e)
  • Marc

    Marc dd1c6d647f326ab90871ed03ef8a35d3ea249adf m

    [ticket/17414] Remove not needed test captchas
    PHPBB-17414

    • tests/functional/fixtures/ext/foo/test_captcha/captcha/test_captcha.php (version dd1c6d647f326ab90871ed03ef8a35d3ea249adf)
    • tests/functional/fixtures/ext/foo/test_captcha/composer.json (version dd1c6d647f326ab90871ed03ef8a35d3ea249adf)
    • tests/functional/fixtures/ext/foo/test_captcha/config/services.yml (version dd1c6d647f326ab90871ed03ef8a35d3ea249adf)
  • Marc

    Marc 1e80400d09d6042df4f7aeb8f1a9439905a6f418 m

    [ticket/17414] Extend unit test coverage for base class
    PHPBB-17414

    • phpBB/phpbb/captcha/factory.php (version 1e80400d09d6042df4f7aeb8f1a9439905a6f418)
    • phpBB/phpbb/captcha/plugins/base.php (version 1e80400d09d6042df4f7aeb8f1a9439905a6f418)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 1e80400d09d6042df4f7aeb8f1a9439905a6f418)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 1e80400d09d6042df4f7aeb8f1a9439905a6f418)
    • tests/captcha/qa_test.php (version 1e80400d09d6042df4f7aeb8f1a9439905a6f418)
    • tests/captcha/turnstile_test.php (version 1e80400d09d6042df4f7aeb8f1a9439905a6f418)
  • Marc

    Marc 38ce4985f47c6caf5d59a30da3b4594b2eb1846d m

    [ticket/17414] Use language class in adm_back_link()
    PHPBB-17414

    • phpBB/includes/functions_acp.php (version 38ce4985f47c6caf5d59a30da3b4594b2eb1846d)
  • Marc

    Marc 3e938ea7653d82d87207e10e764c6e08a41bc161 m

    [ticket/17413] Add full test coverage for turnstile class
    PHPBB-17413

    • tests/captcha/turnstile_test.php (version 3e938ea7653d82d87207e10e764c6e08a41bc161)
  • Marc

    Marc 61e265e4b4a35d749ac2677855ec51d68c4bc0a3 m

    [ticket/17413] Start implementation of unit tests
    PHPBB-17413

    • phpBB/phpbb/captcha/plugins/turnstile.php (version 61e265e4b4a35d749ac2677855ec51d68c4bc0a3)
    • tests/captcha/turnstile_test.php (version 61e265e4b4a35d749ac2677855ec51d68c4bc0a3)
  • Marc

    Marc 9eb18f351bd41e3917f43ca09569043905fc2c6a m

    [ticket/17413] Fix setting solved state on valid confirm code
    PHPBB-17413

    • phpBB/phpbb/captcha/plugins/base.php (version 9eb18f351bd41e3917f43ca09569043905fc2c6a)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 9eb18f351bd41e3917f43ca09569043905fc2c6a)
  • Marc

    Marc db25443bc56f20669e80911f7def4906b0683d76 m

    [ticket/17413] Clean up turnstile code and add attempt counting
    PHPBB-17413

    • phpBB/phpbb/captcha/plugins/base.php (version db25443bc56f20669e80911f7def4906b0683d76)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version db25443bc56f20669e80911f7def4906b0683d76)
    • phpBB/styles/prosilver/template/captcha_turnstile.html (version db25443bc56f20669e80911f7def4906b0683d76)
  • Marc

    Marc cf16a76f0c710057cf2c30bcdccdc4f8fa00adea m

    [ticket/17414] Move more functionality to base and fix turnstile language
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/base.php (version cf16a76f0c710057cf2c30bcdccdc4f8fa00adea)
    • phpBB/phpbb/captcha/plugins/confirm_type.php (version cf16a76f0c710057cf2c30bcdccdc4f8fa00adea)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version cf16a76f0c710057cf2c30bcdccdc4f8fa00adea)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version cf16a76f0c710057cf2c30bcdccdc4f8fa00adea)
    • phpBB/styles/prosilver/template/captcha_turnstile.html (version cf16a76f0c710057cf2c30bcdccdc4f8fa00adea)
  • Marc

    Marc 48454308aeee4bfd664eab2d4ecf8faad57a8f21 m

    [ticket/17414] Replace confirm types with enum
    PHPBB-17414

    • phpBB/includes/constants.php (version 48454308aeee4bfd664eab2d4ecf8faad57a8f21)
    • phpBB/includes/ucp/ucp_register.php (version 48454308aeee4bfd664eab2d4ecf8faad57a8f21)
    • phpBB/phpbb/auth/provider/db.php (version 48454308aeee4bfd664eab2d4ecf8faad57a8f21)
    • phpBB/phpbb/captcha/plugins/confirm_type.php (version 48454308aeee4bfd664eab2d4ecf8faad57a8f21)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 48454308aeee4bfd664eab2d4ecf8faad57a8f21)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 48454308aeee4bfd664eab2d4ecf8faad57a8f21)
    • phpBB/phpbb/report/controller/report.php (version 48454308aeee4bfd664eab2d4ecf8faad57a8f21)
    • phpBB/posting.php (version 48454308aeee4bfd664eab2d4ecf8faad57a8f21)
  • Marc

    Marc 589fe70be6298b719241570860a27dd802dfdcbf m

    [ticket/17414] Change handling of validate to new logic
    PHPBB-17414

    • phpBB/includes/ucp/ucp_register.php (version 589fe70be6298b719241570860a27dd802dfdcbf)
    • phpBB/phpbb/auth/provider/db.php (version 589fe70be6298b719241570860a27dd802dfdcbf)
    • phpBB/phpbb/report/controller/report.php (version 589fe70be6298b719241570860a27dd802dfdcbf)
    • phpBB/posting.php (version 589fe70be6298b719241570860a27dd802dfdcbf)
  • Marc

    Marc c382f81222b856030561ca76879580c9c8c8dac8 m

    [ticket/17413] Add language and theme settings for turnstile
    PHPBB-17413

    • phpBB/adm/style/captcha_turnstile_acp.html (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/adm/style/captcha_turnstile_acp_demo.html (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/install/schemas/schema_data.sql (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/language/en/captcha_turnstile.php (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/language/en/composer.json (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/phpbb/db/migration/data/v400/turnstile_captcha.php (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/phpbb/language/language.php (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/phpbb/language/language_file_helper.php (version c382f81222b856030561ca76879580c9c8c8dac8)
    • phpBB/styles/prosilver/template/captcha_turnstile.html (version c382f81222b856030561ca76879580c9c8c8dac8)
  • Marc

    Marc 8290cdb7e734679f093f100a23d161e65eba0bfb m

    [ticket/17413] Make turnstile captcha work on registration page
    PHPBB-17413

    • phpBB/adm/style/captcha_turnstile_acp_demo.html (version 8290cdb7e734679f093f100a23d161e65eba0bfb)
    • phpBB/language/en/captcha_turnstile.php (version 8290cdb7e734679f093f100a23d161e65eba0bfb)
    • phpBB/phpbb/captcha/plugins/base.php (version 8290cdb7e734679f093f100a23d161e65eba0bfb)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 8290cdb7e734679f093f100a23d161e65eba0bfb)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 8290cdb7e734679f093f100a23d161e65eba0bfb)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 8290cdb7e734679f093f100a23d161e65eba0bfb)
    • phpBB/styles/prosilver/template/captcha_turnstile.html (version 8290cdb7e734679f093f100a23d161e65eba0bfb)
  • Marc

    Marc 01dd0b168a5829fe4f5c3cfff31828ca7fcceaf1 m

    [ticket/17414] Create abstract base class for captchas
    PHPBB-17414

    • phpBB/config/default/container/services_captcha.yml (version 01dd0b168a5829fe4f5c3cfff31828ca7fcceaf1)
    • phpBB/phpbb/captcha/plugins/base.php (version 01dd0b168a5829fe4f5c3cfff31828ca7fcceaf1)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 01dd0b168a5829fe4f5c3cfff31828ca7fcceaf1)
  • Marc

    Marc 2500f722abe074a1905ee1346b26a971f4d10b6f m

    [ticket/17413] Add acp settings for turnstile captcha
    PHPBB-17413

    • phpBB/adm/style/captcha_turnstile_acp.html (version 2500f722abe074a1905ee1346b26a971f4d10b6f)
    • phpBB/config/default/container/services_captcha.yml (version 2500f722abe074a1905ee1346b26a971f4d10b6f)
    • phpBB/language/en/captcha_turnstile.php (version 2500f722abe074a1905ee1346b26a971f4d10b6f)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 2500f722abe074a1905ee1346b26a971f4d10b6f)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 2500f722abe074a1905ee1346b26a971f4d10b6f)
  • Marc

    Marc b55b42d09f3913078c793d78efb9b15eed9aeb67 m

    [ticket/17413] Add migration for turnstile and acp demo
    PHPBB-17413

    • phpBB/adm/style/captcha_turnstile_acp_demo.html (version b55b42d09f3913078c793d78efb9b15eed9aeb67)
    • phpBB/config/default/container/services_captcha.yml (version b55b42d09f3913078c793d78efb9b15eed9aeb67)
    • phpBB/language/en/captcha_turnstile.php (version b55b42d09f3913078c793d78efb9b15eed9aeb67)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version b55b42d09f3913078c793d78efb9b15eed9aeb67)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version b55b42d09f3913078c793d78efb9b15eed9aeb67)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version b55b42d09f3913078c793d78efb9b15eed9aeb67)
    • phpBB/phpbb/db/migration/data/v400/turnstile_captcha.php (version b55b42d09f3913078c793d78efb9b15eed9aeb67)
  • Marc

    Marc 52acd2709ba4c8fffaf29a7f42b4f182ce971faa m

    [ticket/17413] Continue implementation of turnstile captcha
    PHPBB-17413

    • phpBB/config/default/container/services_captcha.yml (version 52acd2709ba4c8fffaf29a7f42b4f182ce971faa)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 52acd2709ba4c8fffaf29a7f42b4f182ce971faa)
  • Marc

    Marc 2a6609013da1841ac37cae3e6ccf56f642bb307a m

    [ticket/17414] Remove request data from validate call
    PHPBB-17414

    • phpBB/includes/ucp/ucp_register.php (version 2a6609013da1841ac37cae3e6ccf56f642bb307a)
    • phpBB/phpbb/auth/provider/db.php (version 2a6609013da1841ac37cae3e6ccf56f642bb307a)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 2a6609013da1841ac37cae3e6ccf56f642bb307a)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 2a6609013da1841ac37cae3e6ccf56f642bb307a)
  • Marc

    Marc 6a34de543b02eba8dde831bf96dfd3d780d72e9a m

    [ticket/17414] Add get_template function to plugin interface
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 6a34de543b02eba8dde831bf96dfd3d780d72e9a)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 6a34de543b02eba8dde831bf96dfd3d780d72e9a)
  • Marc

    Marc d85267707c01d69338014fb4cae5b12a66fc991d m

    [ticket/17414] Add placeholder when there are no questions yet
    PHPBB-17414

    • phpBB/adm/style/captcha_qa_acp.html (version d85267707c01d69338014fb4cae5b12a66fc991d)
    • phpBB/language/en/captcha_qa.php (version d85267707c01d69338014fb4cae5b12a66fc991d)
  • Marc

    Marc c02f8688c4964749b85bc5dcb9cfebc16faf5c35 m

    [ticket/17414] Convert acp captcha html to twig syntax
    PHPBB-17414

    • phpBB/adm/style/acp_captcha.html (version c02f8688c4964749b85bc5dcb9cfebc16faf5c35)
  • Marc

    Marc 8de8878d5e48b1c9febb311859bf3a10f9559ff3 m

    [ticket/17414] Move captcha acp html to html files
    PHPBB-17414

    • phpBB/adm/style/acp_captcha.html (version 8de8878d5e48b1c9febb311859bf3a10f9559ff3)
    • phpBB/includes/acp/acp_captcha.php (version 8de8878d5e48b1c9febb311859bf3a10f9559ff3)
  • Marc

    Marc c27c1fa7a3ddf35c4c79da43239804b83f6ca9e4 m

    [ticket/17414] Support adding onchange to select
    PHPBB-17414

    • phpBB/phpbb/template/twig/extension/forms.php (version c27c1fa7a3ddf35c4c79da43239804b83f6ca9e4)
    • phpBB/styles/all/template/macros/forms/select.twig (version c27c1fa7a3ddf35c4c79da43239804b83f6ca9e4)
  • Marc

    Marc edce13c7779cead54d94b0fac26e96f5dc6eaca0 m

    [ticket/17414] Add get_hidden_fields to interface
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version edce13c7779cead54d94b0fac26e96f5dc6eaca0)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version edce13c7779cead54d94b0fac26e96f5dc6eaca0)
  • Marc

    Marc 3676e895f3bbe9b96bd08a7ab7dfdf0126a8373f m

    [ticket/17414] Remove uninstall method from captcha plugins
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/captcha_abstract.php (version 3676e895f3bbe9b96bd08a7ab7dfdf0126a8373f)
    • phpBB/phpbb/captcha/plugins/qa.php (version 3676e895f3bbe9b96bd08a7ab7dfdf0126a8373f)
    • phpBB/phpbb/captcha/plugins/recaptcha.php (version 3676e895f3bbe9b96bd08a7ab7dfdf0126a8373f)
  • Marc

    Marc 8429145241759a0966caf7f28085ddd59e63f4b0 m

    [ticket/17414] Remove install steps for captcha plugins
    This should be handled by migrations instead.

    PHPBB-17414

    • phpBB/includes/acp/acp_captcha.php (version 8429145241759a0966caf7f28085ddd59e63f4b0)
    • phpBB/phpbb/captcha/plugins/captcha_abstract.php (version 8429145241759a0966caf7f28085ddd59e63f4b0)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 8429145241759a0966caf7f28085ddd59e63f4b0)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 8429145241759a0966caf7f28085ddd59e63f4b0)
    • phpBB/phpbb/captcha/plugins/qa.php (version 8429145241759a0966caf7f28085ddd59e63f4b0)
    • phpBB/phpbb/captcha/plugins/recaptcha.php (version 8429145241759a0966caf7f28085ddd59e63f4b0)
  • Marc

    Marc 89bb72c277cf2c10a1f58182fdd0da962752c874 m

    [ticket/17415] Correctly wrap legacy captchas
    PHPBB-17415

    • phpBB/phpbb/captcha/factory.php (version 89bb72c277cf2c10a1f58182fdd0da962752c874)
  • Marc

    Marc ae9f97b7e2dd8b75b23d62c8ee26ab99d96355f6 m

    [ticket/17415] Move install step of Q&A to migration
    PHPBB-17415

    • phpBB/phpbb/captcha/plugins/qa.php (version ae9f97b7e2dd8b75b23d62c8ee26ab99d96355f6)
    • phpBB/phpbb/db/migration/data/v400/qa_captcha.php (version ae9f97b7e2dd8b75b23d62c8ee26ab99d96355f6)
  • Marc

    Marc e84e9cace4e10b2a6d5a759d9ab82ffc3e313521 m

    [ticket/17414] Extend plugin interface and wrapper
    PHPBB-17414

    • phpBB/includes/ucp/ucp_register.php (version e84e9cace4e10b2a6d5a759d9ab82ffc3e313521)
    • phpBB/phpbb/captcha/factory.php (version e84e9cace4e10b2a6d5a759d9ab82ffc3e313521)
    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version e84e9cace4e10b2a6d5a759d9ab82ffc3e313521)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version e84e9cace4e10b2a6d5a759d9ab82ffc3e313521)
    • phpBB/posting.php (version e84e9cace4e10b2a6d5a759d9ab82ffc3e313521)
  • Marc

    Marc 15b51e3b8f8f9aeeeecf6522d83377233e909060 m

    [ticket/17414] Deprecate captcha constants
    PHPBB-17414

    • phpBB/includes/constants.php (version 15b51e3b8f8f9aeeeecf6522d83377233e909060)
  • Marc

    Marc 1b8918448975b923fac78445ecfa5fe6e9dfe554 m

    [ticket/17415] Start adding legacy wrapper for old captchas
    PHPBB-17415

    • phpBB/phpbb/captcha/plugins/legacy_wrapper.php (version 1b8918448975b923fac78445ecfa5fe6e9dfe554)
    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version 1b8918448975b923fac78445ecfa5fe6e9dfe554)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version 1b8918448975b923fac78445ecfa5fe6e9dfe554)
  • Marc

    Marc b828c56dc926dc47029834235c08e6b876f53e7f m

    [ticket/17414] Start work on new captcha classes
    PHPBB-17414

    • phpBB/phpbb/captcha/plugins/plugin_interface.php (version b828c56dc926dc47029834235c08e6b876f53e7f)
    • phpBB/phpbb/captcha/plugins/turnstile.php (version b828c56dc926dc47029834235c08e6b876f53e7f)
    • tests/functional/fixtures/ext/foo/test_captcha/captcha/test_captcha.php (version b828c56dc926dc47029834235c08e6b876f53e7f)
    • tests/functional/fixtures/ext/foo/test_captcha/composer.json (version b828c56dc926dc47029834235c08e6b876f53e7f)
    • tests/functional/fixtures/ext/foo/test_captcha/config/services.yml (version b828c56dc926dc47029834235c08e6b876f53e7f)