Build #1,394

Plan branch:

Build: #1394 was successful Changes by Marc

Stages & jobs

  1. Default Stage

Code commits

phpBB Master

  • Marc

    Marc 3584ef7ecab35fdec2890b07b7fae79aced51eb6

    Merge pull request #6753 from rubencm/ticket/17361
    [ticket/17361] Improve storage

  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> c9ff5a09f61ebf1bc3cd56c094d7a08f0b117566 m

    [ticket/17361] Fix file not deleted when there is an error
    PHPBB-17361

    • phpBB/phpbb/files/filespec_storage.php (version c9ff5a09f61ebf1bc3cd56c094d7a08f0b117566)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 921505ca3bf190d18d5dd412a2c7908548ec7b65 m

    [ticket/17361] Fix code style
    PHPBB-17361

    • phpBB/phpbb/db/migration/data/v400/storage_track.php (version 921505ca3bf190d18d5dd412a2c7908548ec7b65)
    • phpBB/phpbb/storage/file_tracker.php (version 921505ca3bf190d18d5dd412a2c7908548ec7b65)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 598d1c7f49586110ad2b70c61b178c41f078b094 m

    [ticket/17361] Change order of arguments
    PHPBB-17361

    • phpBB/config/default/container/services_storage.yml (version 598d1c7f49586110ad2b70c61b178c41f078b094)
    • phpBB/phpbb/storage/file_tracker.php (version 598d1c7f49586110ad2b70c61b178c41f078b094)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 90bd9d006e768fb96e3f093481c1af9b1e3aa0e6 m

    [ticket/17361] Add method to track multiple files in a single query
    PHPBB-17361

    • phpBB/phpbb/db/migration/data/v400/storage_track.php (version 90bd9d006e768fb96e3f093481c1af9b1e3aa0e6)
    • phpBB/phpbb/storage/file_tracker.php (version 90bd9d006e768fb96e3f093481c1af9b1e3aa0e6)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> b33f17e7ce630f5860f26f4f7c1c5824dd9472ec m

    [ticket/17361] Use filesystem classes for tempnam and temp dir. Code reviews.
    PHPBB-17361

    • phpBB/config/default/container/services_console.yml (version b33f17e7ce630f5860f26f4f7c1c5824dd9472ec)
    • phpBB/phpbb/console/command/thumbnail/generate.php (version b33f17e7ce630f5860f26f4f7c1c5824dd9472ec)
    • phpBB/phpbb/console/command/thumbnail/recreate.php (version b33f17e7ce630f5860f26f4f7c1c5824dd9472ec)
    • phpBB/phpbb/db/migration/data/v400/storage_backup_data.php (version b33f17e7ce630f5860f26f4f7c1c5824dd9472ec)
    • phpBB/phpbb/filesystem/temp.php (version b33f17e7ce630f5860f26f4f7c1c5824dd9472ec)
    • phpBB/phpbb/storage/file_tracker.php (version b33f17e7ce630f5860f26f4f7c1c5824dd9472ec)
    • tests/console/thumbnail_test.php (version b33f17e7ce630f5860f26f4f7c1c5824dd9472ec)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> d6953a0422dd0ff6e967caa45db2df9b3b1a4421 m

    [ticket/17361] Use new adapter options format in acp_storage
    PHPBB-17361

    • phpBB/includes/acp/acp_storage.php (version d6953a0422dd0ff6e967caa45db2df9b3b1a4421)
    • phpBB/phpbb/db/migration/data/v400/storage_backup_data.php (version d6953a0422dd0ff6e967caa45db2df9b3b1a4421)
    • phpBB/phpbb/language/language.php (version d6953a0422dd0ff6e967caa45db2df9b3b1a4421)
    • phpBB/phpbb/storage/adapter_factory.php (version d6953a0422dd0ff6e967caa45db2df9b3b1a4421)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> a44295a1ba21fa3141dedf151db405ecd9448232 m

    [ticket/17361] Move language keys to storage adapters
    PHPBB-17361

    • phpBB/adm/style/acp_storage.html (version a44295a1ba21fa3141dedf151db405ecd9448232)
    • phpBB/config/default/container/services_storage.yml (version a44295a1ba21fa3141dedf151db405ecd9448232)
    • phpBB/language/en/acp/storage.php (version a44295a1ba21fa3141dedf151db405ecd9448232)
    • phpBB/phpbb/storage/provider/local.php (version a44295a1ba21fa3141dedf151db405ecd9448232)
    • phpBB/phpbb/storage/provider/provider_interface.php (version a44295a1ba21fa3141dedf151db405ecd9448232)
    • phpBB/phpbb/template/twig/extension/forms.php (version a44295a1ba21fa3141dedf151db405ecd9448232)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> be3966c0cbd3558670a75a4062e6c74ac5a1cb1e m

    [ticket/17361] Remove temp files always
    PHPBB-17361

    • phpBB/phpbb/console/command/thumbnail/delete.php (version be3966c0cbd3558670a75a4062e6c74ac5a1cb1e)
    • phpBB/phpbb/console/command/thumbnail/generate.php (version be3966c0cbd3558670a75a4062e6c74ac5a1cb1e)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 1f7ae9e2b0d9d487e1be6c9136d301c07b519b48 m

    [ticket/17361] Fix migrations
    PHPBB-17361

    • phpBB/includes/acp/acp_database.php (version 1f7ae9e2b0d9d487e1be6c9136d301c07b519b48)
    • phpBB/phpbb/db/migration/data/v400/storage_attachment.php (version 1f7ae9e2b0d9d487e1be6c9136d301c07b519b48)
    • phpBB/phpbb/db/migration/data/v400/storage_avatar.php (version 1f7ae9e2b0d9d487e1be6c9136d301c07b519b48)
    • phpBB/phpbb/db/migration/data/v400/storage_backup.php (version 1f7ae9e2b0d9d487e1be6c9136d301c07b519b48)
    • phpBB/phpbb/db/migration/data/v400/storage_backup_data.php (version 1f7ae9e2b0d9d487e1be6c9136d301c07b519b48)
    • phpBB/phpbb/db/migration/data/v400/storage_track.php (version 1f7ae9e2b0d9d487e1be6c9136d301c07b519b48)
    • phpBB/phpbb/storage/adapter_factory.php (version 1f7ae9e2b0d9d487e1be6c9136d301c07b519b48)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> a8399c14319378bc0a008a87821dcb11abf04088 m

    [ticket/17361] Use storage in commands create and delete thumbnail
    PHPBB-17361

    • phpBB/config/default/container/services_console.yml (version a8399c14319378bc0a008a87821dcb11abf04088)
    • phpBB/phpbb/console/command/thumbnail/delete.php (version a8399c14319378bc0a008a87821dcb11abf04088)
    • phpBB/phpbb/console/command/thumbnail/generate.php (version a8399c14319378bc0a008a87821dcb11abf04088)
    • phpBB/phpbb/console/command/thumbnail/recreate.php (version a8399c14319378bc0a008a87821dcb11abf04088)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 4becf438e12f43ca3bd07fb7cd2cb6767fcbc231 m

    [ticket/17361] Remove temp files
    PHPBB-17361

    • phpBB/phpbb/console/command/thumbnail/generate.php (version 4becf438e12f43ca3bd07fb7cd2cb6767fcbc231)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 6d9a8ae8afce9b45bebd55abb58d3c175b4fe06c m

    [ticket/17361] Remove fclose after write
    PHPBB-17361

    • phpBB/phpbb/attachment/upload.php (version 6d9a8ae8afce9b45bebd55abb58d3c175b4fe06c)
    • phpBB/phpbb/files/filespec_storage.php (version 6d9a8ae8afce9b45bebd55abb58d3c175b4fe06c)
    • phpBB/phpbb/storage/helper.php (version 6d9a8ae8afce9b45bebd55abb58d3c175b4fe06c)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 9bf9538dc642aeb2ae076bdbe8aad125bc566458 m

    [ticket/17361] Update thumbnail_test test
    PHPBB-17361

    • phpBB/phpbb/console/command/thumbnail/generate.php (version 9bf9538dc642aeb2ae076bdbe8aad125bc566458)
    • tests/console/thumbnail_test.php (version 9bf9538dc642aeb2ae076bdbe8aad125bc566458)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> e9c445925b6fd42936dde13357d8e33329748bf0 m

    [ticket/17361] Rewrite storage
    PHPBB-17361

    • phpBB/adm/style/acp_storage.html (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/config/default/container/services_storage.yml (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/includes/acp/acp_database.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/includes/acp/acp_main.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/includes/acp/acp_storage.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/includes/functions_user.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/attachment/upload.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/db/migration/data/v400/storage_track.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/db/migration/data/v400/storage_track_index.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/files/filespec_storage.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/adapter/adapter_interface.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/adapter/local.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/adapter_factory.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/controller/attachment.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/controller/avatar.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/controller/controller.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/exception/storage_exception.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/file_tracker.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/helper.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/provider/local.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/provider/provider_interface.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/storage.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • phpBB/phpbb/storage/stream_interface.php (version e9c445925b6fd42936dde13357d8e33329748bf0)
    • tests/storage/adapter/local_test.php (version e9c445925b6fd42936dde13357d8e33329748bf0)