Build #314

Plan branch:

Build: #314 was successful Changes by Derky <derky@phpbb.com>

Stages & jobs

  1. Default Stage

Code commits

phpBB Master

  • Derky <derky@phpbb.com>

    Derky <derky@phpbb.com> 7d5276e7dc0b050d3db2da7c873c04dbc189dca7

    Merge branch '3.2.x'

  • Derky <derky@phpbb.com>

    Derky <derky@phpbb.com> 2fcb8ab87fb30c57b106695859c2661fc3cc2837 m

    Merge pull request #5069 from marc1706/ticket/14972-rhea
    [ticket/14972] Backport for PHP 7.2 compatibility

  • Marc

    Marc c1ec6517bfe0f080ad052e727073794583464bfb m

    [ticket/14972] Add PHP 7.2 to build matrix
    PHPBB3-14972

    • .travis.yml (version c1ec6517bfe0f080ad052e727073794583464bfb)
  • Marc

    Marc ff18802656e72981f6ecb613d756bc19f2462689 m

    [ticket/14972] Fix template context use of sizeof()
    PHPBB3-14972

    • phpBB/phpbb/template/context.php (version ff18802656e72981f6ecb613d756bc19f2462689)
  • rxu

    rxu f8fbe3793680af1dae2db2829cfc84068831c52f m

    [ticket/14972] replace all occurrences of sizeof() with the count()
    PHPBB3-14972

    • build/build_helper.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • build/package.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/develop/add_permissions.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/develop/check_flash_bbcodes.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/develop/create_variable_overview.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/develop/search_fill.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/docs/coding-guidelines.html (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_attachments.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_bbcodes.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_board.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_bots.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_database.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_email.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_forums.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_groups.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_help_phpbb.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_icons.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_inactive.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_language.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_logs.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_main.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_modules.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_permission_roles.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_permissions.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_profile.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_prune.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_reasons.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_search.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/acp_users.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/acp/auth.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/bbcode.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/diff/diff.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/diff/engine.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/diff/renderer.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_admin.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_compress.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_content.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_convert.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_display.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_download.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_jabber.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_mcp.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_messenger.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_module.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_posting.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_privmsgs.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/functions_transfer.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_ban.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_forum.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_logs.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_main.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_pm_reports.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_post.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_queue.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_reports.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/mcp/mcp_topic.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/message_parser.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_attachments.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_auth_link.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_groups.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_main.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_notifications.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_pm_compose.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_pm_options.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_pm_viewfolder.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_pm_viewmessage.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_prefs.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_profile.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_register.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/ucp/ucp_zebra.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/includes/utf/utf_tools.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/install/convert/controller/convertor.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/install/convert/convertor.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/install/convertors/functions_phpbb20.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/mcp.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/memberlist.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/attachment/resync.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/attachment/upload.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/auth/auth.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/auth/provider/ldap.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/auth/provider/oauth/oauth.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/avatar/driver/local.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/avatar/driver/upload.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/cache/driver/base.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/cache/driver/file.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/cache/driver/memory.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/cache/service.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/captcha/char_cube3d.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/captcha/colour_manager.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/captcha/gd.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/captcha/plugins/captcha_abstract.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/captcha/plugins/qa.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/console/command/thumbnail/delete.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/content_visibility.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/driver/mssqlnative.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/driver/oracle.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/extractor/mssql_extractor.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/extractor/oracle_extractor.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/migration/data/v310/style_update_p1.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/migration/data/v310/teampage.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/migration/tool/config.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/migration/tool/config_text.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/migration/tool/module.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/migration/tool/permission.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/migrator.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/sql_insert_buffer.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/db/tools/mssql.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/event/md_exporter.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/event/php_exporter.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/files/filespec.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/files/types/form.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/files/types/local.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/filesystem/filesystem.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/helper/database.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/helper/iohandler/ajax_iohandler.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/module/install_data/task/add_bots.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/module/install_data/task/add_modules.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/module/install_database/task/add_config_settings.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/module/install_database/task/add_default_data.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/module/install_database/task/add_tables.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/module/install_finish/task/install_extensions.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/module/update_database/task/update_extensions.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/install/module/update_filesystem/task/diff_files.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/language/language.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/language/language_file_loader.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/log/log.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/message/form.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/message/message.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/module/module_manager.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/notification/manager.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/notification/type/pm.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/notification/type/post.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/notification/type/topic.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/profilefields/manager.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/profilefields/type/type_bool.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/profilefields/type/type_dropdown.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/report/controller/report.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/search/base.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/search/fulltext_mysql.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/search/fulltext_native.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/search/fulltext_postgres.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/search/fulltext_sphinx.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/search/sphinx/config.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/search/sphinx/config_section.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/template/twig/extension.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/tree/nestedset.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/phpbb/user_loader.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/posting.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/search.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/viewforum.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • phpBB/viewtopic.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/cache/cache_memory_test.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/cron/manager_test.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/dbal/write_test.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/event/md_exporter_test.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/functional/fileupload_remote_test.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/functions/get_remote_file_test.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/mock/sql_insert_buffer.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/notification/base.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/test_framework/phpbb_database_test_case.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/test_framework/phpbb_database_test_connection_manager.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/test_framework/phpbb_functional_test_case.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/test_framework/phpbb_ui_test_case.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/upload/fileupload_test.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
    • tests/wrapper/version_compare_test.php (version f8fbe3793680af1dae2db2829cfc84068831c52f)
  • rxu

    rxu 11e09f1b3c943695ff688f7a86fdebff88649cef m

    [ticket/14972] Fix test_collection_with_mask test
    In PHP 7.2, the severity of the message “Use of undefined constant” was raised
    from E_NOTICE to E_WARNING, so calling $array[ITEM] causes warning caught by
    error collector. Use undefined offset notice to get an empty message as such.

    PHPBB3-14972

    • tests/error_collector_test.php (version 11e09f1b3c943695ff688f7a86fdebff88649cef)
  • rxu

    rxu dec06d10fedb43bc948fe438b6f581ac7caa1916 m

    [ticket/14972] Fix use of deprecated media attachment constants
    PHPBB3-14972

    • phpBB/phpbb/db/migration/data/v320/remove_outdated_media.php (version dec06d10fedb43bc948fe438b6f581ac7caa1916)
  • rxu

    rxu 6e6195c303c23e66419ffed9fbc3b19856614afc m

    [ticket/14972] Avoid using self as constant in tests
    PHPBB3-14972

    • tests/functional/extension_acp_test.php (version 6e6195c303c23e66419ffed9fbc3b19856614afc)
    • tests/functional/extension_controller_test.php (version 6e6195c303c23e66419ffed9fbc3b19856614afc)
    • tests/functional/extension_global_lang_test.php (version 6e6195c303c23e66419ffed9fbc3b19856614afc)
    • tests/functional/extension_module_test.php (version 6e6195c303c23e66419ffed9fbc3b19856614afc)
    • tests/functional/extension_permission_lang_test.php (version 6e6195c303c23e66419ffed9fbc3b19856614afc)
    • tests/functional/metadata_manager_test.php (version 6e6195c303c23e66419ffed9fbc3b19856614afc)
  • rxu

    rxu e1376e14ded58c3f4135253d7329db0676e49c87 m

    [ticket/14972] Fix create_insert_array() declaration in admin_activate_user
    PHPBB3-14972

    • phpBB/phpbb/notification/type/admin_activate_user.php (version e1376e14ded58c3f4135253d7329db0676e49c87)
  • rxu

    rxu 8c3808e9e7db09531154b2520cbfcc7529a5c752 m

    [ticket/14972] Fix sizeof calls
    As of PHP 7.2, only arrays and objects implementing the Countable interface
    should be passed as a count() or sizeof() parameter.
    See https://github.com/php/php-src/blob/php-7.2.0alpha2/UPGRADING#L197-L198
    Also, sizeof() seems to be sheduled for deprecation, see
    https://wiki.php.net/rfc/deprecations_php_7_2#suggested_deprecations

    PHPBB3-14972

    • phpBB/includes/functions.php (version 8c3808e9e7db09531154b2520cbfcc7529a5c752)
    • phpBB/includes/functions_admin.php (version 8c3808e9e7db09531154b2520cbfcc7529a5c752)
    • phpBB/includes/functions_user.php (version 8c3808e9e7db09531154b2520cbfcc7529a5c752)
    • phpBB/phpbb/db/driver/driver.php (version 8c3808e9e7db09531154b2520cbfcc7529a5c752)
    • phpBB/phpbb/session.php (version 8c3808e9e7db09531154b2520cbfcc7529a5c752)