Build #374

Plan branch:

Build: #374 was successful Changes by Rubén Calvo <rubencm@gmail.com> and Marc

Stages & jobs

  1. Default Stage

Code commits

phpBB Master

  • Marc

    Marc 5087d5d6b659643617368df439a070fc51b39492

    Merge pull request #4933 from rubencm/ticket/15342
    [ticket/15342] Track storage files

  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> e40daea4bdec4bf4f39efdfe166428b0834fc261

    [ticket/15342] Update comments
    PHPBB3-15342

    • phpBB/phpbb/storage/adapter/adapter_interface.php (version e40daea4bdec4bf4f39efdfe166428b0834fc261)
    • phpBB/phpbb/storage/adapter/local.php (version e40daea4bdec4bf4f39efdfe166428b0834fc261)
    • phpBB/phpbb/storage/exception/exception.php (version e40daea4bdec4bf4f39efdfe166428b0834fc261)
    • phpBB/phpbb/storage/file_info.php (version e40daea4bdec4bf4f39efdfe166428b0834fc261)
    • phpBB/phpbb/storage/provider/provider_interface.php (version e40daea4bdec4bf4f39efdfe166428b0834fc261)
    • phpBB/phpbb/storage/storage.php (version e40daea4bdec4bf4f39efdfe166428b0834fc261)
    • phpBB/phpbb/storage/stream_interface.php (version e40daea4bdec4bf4f39efdfe166428b0834fc261)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 5a1b4f559d53f65befdd894c678536113c5415ab

    [ticket/15342] Add avatar storage size to acp_main
    PHPBB3-15342

    • phpBB/includes/acp/acp_main.php (version 5a1b4f559d53f65befdd894c678536113c5415ab)
    • phpBB/phpbb/storage/storage.php (version 5a1b4f559d53f65befdd894c678536113c5415ab)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> c039fcba1859de35d8520b347c2fd4298ddb87b0

    [ticket/15342] free_space() now return false if there is any error
    PHPBB3-15342

    • phpBB/phpbb/storage/adapter/adapter_interface.php (version c039fcba1859de35d8520b347c2fd4298ddb87b0)
    • phpBB/phpbb/storage/adapter/local.php (version c039fcba1859de35d8520b347c2fd4298ddb87b0)
    • phpBB/phpbb/storage/storage.php (version c039fcba1859de35d8520b347c2fd4298ddb87b0)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 22b2e955319a51d8ff9376710aa6c3088c88a45d

    [ticket/15342] Add again check of free space when uploading attachments
    PHPBB3-15342

    • phpBB/phpbb/attachment/upload.php (version 22b2e955319a51d8ff9376710aa6c3088c88a45d)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> e9dd717b8b235b404b28e02574c9b764b01f4a95

    [ticket/15342] Track stream write and move tracking to separate methods
    PHPBB3-15342

    • phpBB/phpbb/storage/storage.php (version e9dd717b8b235b404b28e02574c9b764b01f4a95)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 117d9e69cece6b07c1ac064981339194347229d6

    [ticket/15342] Fix comments
    PHPBB3-15342

    • phpBB/phpbb/storage/adapter/adapter_interface.php (version 117d9e69cece6b07c1ac064981339194347229d6)
    • phpBB/phpbb/storage/storage.php (version 117d9e69cece6b07c1ac064981339194347229d6)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 7d7217c38187bfa5b644d49a061e18533520cf5f

    [ticket/15342] Move call to remove file
    PHPBB3-15342

    • phpBB/phpbb/attachment/upload.php (version 7d7217c38187bfa5b644d49a061e18533520cf5f)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 4cff370f8d7c201874de2b7f79b4dd59506ce008

    [ticket/15342] Add method to get free space
    PHPBB3-15342

    • phpBB/phpbb/storage/adapter/adapter_interface.php (version 4cff370f8d7c201874de2b7f79b4dd59506ce008)
    • phpBB/phpbb/storage/adapter/local.php (version 4cff370f8d7c201874de2b7f79b4dd59506ce008)
    • phpBB/phpbb/storage/storage.php (version 4cff370f8d7c201874de2b7f79b4dd59506ce008)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 80e5fe255bc11030d6c23780ef42e8f57a0ab6ee

    [ticket/15342] Add method to storage to get number of tracked files
    PHPBB3-15342

    • phpBB/phpbb/storage/storage.php (version 80e5fe255bc11030d6c23780ef42e8f57a0ab6ee)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 83d559afc58c76c54dc8241bd3ef51a1b533fe01

    [ticket/15342] Track attachments thumbnails
    PHPBB3-15342

    • phpBB/phpbb/db/migration/data/v330/storage_track.php (version 83d559afc58c76c54dc8241bd3ef51a1b533fe01)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> b823ae85cf55ec3de0428c0d2bb4873303a6a854

    [ticket/15342] Track current uploaded files
    PHPBB3-15342

    • phpBB/phpbb/db/migration/data/v330/storage_track.php (version b823ae85cf55ec3de0428c0d2bb4873303a6a854)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 1d686fecb54fa8074be964fbe5d9d0d078eea8d1

    [ticket/15342] Fix parameter that could be null
    PHPBB3-15342

    • phpBB/phpbb/storage/storage.php (version 1d686fecb54fa8074be964fbe5d9d0d078eea8d1)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 171b56b0ac73c99448b942448e6d6c92a2912b3f

    [ticket/15342] Add missing services dependencies
    PHPBB3-15342

    • phpBB/config/default/container/services_storage.yml (version 171b56b0ac73c99448b942448e6d6c92a2912b3f)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 0e0e157e871e31f4e07ef5f7f821bc026cd13ed9

    [ticket/15342] If the file haven't been moved, remove it from the filesystem
    PHPBB3-15342

    • phpBB/phpbb/files/filespec_storage.php (version 0e0e157e871e31f4e07ef5f7f821bc026cd13ed9)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 9184d34a51f935d51a03c7f25d633bbec310ff5f

    [ticket/15342] Use cache to get the number of files and the size of any storage
    PHPBB3-15342

    • phpBB/config/default/container/services_storage.yml (version 9184d34a51f935d51a03c7f25d633bbec310ff5f)
    • phpBB/phpbb/storage/storage.php (version 9184d34a51f935d51a03c7f25d633bbec310ff5f)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 6d2aae5853ae15fcb036a88bdc3a539b50e87740

    [ticket/15342] Fix docblock
    PHPBB3-15342

    • phpBB/phpbb/attachment/upload.php (version 6d2aae5853ae15fcb036a88bdc3a539b50e87740)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 0cc77d2c992ec99c2abccacd4a0c7be3927178d7

    [ticket/15342] Check if is resource before close it
    PHPBB3-15342

    • phpBB/includes/acp/acp_database.php (version 0cc77d2c992ec99c2abccacd4a0c7be3927178d7)
    • phpBB/phpbb/attachment/upload.php (version 0cc77d2c992ec99c2abccacd4a0c7be3927178d7)
    • phpBB/phpbb/files/filespec_storage.php (version 0cc77d2c992ec99c2abccacd4a0c7be3927178d7)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> f9c19013179b2a2e6a8e4de017e7d459de613142

    [ticket/15342] Fix test
    PHPBB3-15342

    • phpBB/phpbb/db/migration/data/v330/storage_track.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
    • phpBB/phpbb/storage/storage.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
    • tests/attachment/delete_test.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
    • tests/attachment/upload_test.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
    • tests/avatar/manager_test.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
    • tests/content_visibility/delete_post_test.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
    • tests/functions_user/delete_user_test.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
    • tests/notification/submit_post_base.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
    • tests/privmsgs/delete_user_pms_test.php (version f9c19013179b2a2e6a8e4de017e7d459de613142)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 78c86746438a17215ea24d0e4cfca8e34f8e1ef3

    [ticket/15342] Fix check_disk_space
    PHPBB3-15342

    • phpBB/phpbb/attachment/upload.php (version 78c86746438a17215ea24d0e4cfca8e34f8e1ef3)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 238247b5fc390e1172f31f021deb1aaa937b3484

    [ticket/15342] Remove unused variables
    PHPBB3-15342

    • tests/content_visibility/delete_post_test.php (version 238247b5fc390e1172f31f021deb1aaa937b3484)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> bdf3a0c913b14b1a9dda8e5f434cb6deabf14670

    [ticket/15342] Escape strings in sql querys
    PHPBB3-15342

    • phpBB/phpbb/storage/adapter/adapter_interface.php (version bdf3a0c913b14b1a9dda8e5f434cb6deabf14670)
    • phpBB/phpbb/storage/storage.php (version bdf3a0c913b14b1a9dda8e5f434cb6deabf14670)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> af7e3662b834ac41131467464b5952627a36d6a6

    [ticket/15342] Catch exception in check_disk_space
    PHPBB3-15342

    • phpBB/phpbb/attachment/upload.php (version af7e3662b834ac41131467464b5952627a36d6a6)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> b91ce7610bff37a525f4689f43eb50049acf00e2

    [ticket/15342] Fix tests
    PHPBB3-15342

    • tests/attachment/delete_test.php (version b91ce7610bff37a525f4689f43eb50049acf00e2)
    • tests/functions_user/delete_user_test.php (version b91ce7610bff37a525f4689f43eb50049acf00e2)
    • tests/notification/submit_post_base.php (version b91ce7610bff37a525f4689f43eb50049acf00e2)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> db9daf1deac3a9aadef1afd76ca0c72b94dccd04

    [ticket/15342] Fix docblock
    PHPBB3-15342

    • phpBB/phpbb/storage/adapter/adapter_interface.php (version db9daf1deac3a9aadef1afd76ca0c72b94dccd04)
    • phpBB/phpbb/storage/adapter/local.php (version db9daf1deac3a9aadef1afd76ca0c72b94dccd04)
    • phpBB/phpbb/storage/storage.php (version db9daf1deac3a9aadef1afd76ca0c72b94dccd04)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> cc7178a6e0731d03ada3d0425b4b59b3976f17a9

    [ticket/15342] Small improvements to storage
    PHPBB3-15342

    • phpBB/includes/acp/acp_database.php (version cc7178a6e0731d03ada3d0425b4b59b3976f17a9)
    • phpBB/phpbb/attachment/upload.php (version cc7178a6e0731d03ada3d0425b4b59b3976f17a9)
    • phpBB/phpbb/storage/storage.php (version cc7178a6e0731d03ada3d0425b4b59b3976f17a9)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 28c0db86cff62bdd21e84ead2fb729e6d3fcaad4

    [ticket/15342] Add dependencies to migration
    PHPBB3-15342

    • phpBB/phpbb/db/migration/data/v330/storage_track.php (version 28c0db86cff62bdd21e84ead2fb729e6d3fcaad4)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> a3d949c3d0d596b977a7d38f68e047feab8ff805

    [ticket/15342] Fix migration
    PHPBB3-15342

    • phpBB/phpbb/db/migration/data/v330/storage_track.php (version a3d949c3d0d596b977a7d38f68e047feab8ff805)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> e5d8b1600b8af932172396f6ec38cb771032a94b

    [ticket/15342] free_space return float and throws exception
    PHPBB3-15342

    • phpBB/phpbb/storage/adapter/adapter_interface.php (version e5d8b1600b8af932172396f6ec38cb771032a94b)
    • phpBB/phpbb/storage/adapter/local.php (version e5d8b1600b8af932172396f6ec38cb771032a94b)
    • phpBB/phpbb/storage/storage.php (version e5d8b1600b8af932172396f6ec38cb771032a94b)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> a02fa1170be6911cd4c85bc9dd88f216b1384f52

    [ticket/15342] Track storage files
    PHPBB3-15342

    • phpBB/config/default/container/services_storage.yml (version a02fa1170be6911cd4c85bc9dd88f216b1384f52)
    • phpBB/config/default/container/tables.yml (version a02fa1170be6911cd4c85bc9dd88f216b1384f52)
    • phpBB/includes/constants.php (version a02fa1170be6911cd4c85bc9dd88f216b1384f52)
    • phpBB/phpbb/db/migration/data/v330/storage_track.php (version a02fa1170be6911cd4c85bc9dd88f216b1384f52)
    • phpBB/phpbb/storage/storage.php (version a02fa1170be6911cd4c85bc9dd88f216b1384f52)
    • tests/avatar/manager_test.php (version a02fa1170be6911cd4c85bc9dd88f216b1384f52)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 3ed63388b4e2e1292a38e6870a8d56a7abe9b42b

    [ticket/15342] Use track_rename when renaming files
    PHPBB3-15342

    • phpBB/phpbb/storage/storage.php (version 3ed63388b4e2e1292a38e6870a8d56a7abe9b42b)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 91026b56b9c9cebcd707d69a02db1b03708d0175

    [ticket/15342] Track current uploaded files
    PHPBB3-15342

    • phpBB/phpbb/db/migration/data/v330/storage_track.php (version 91026b56b9c9cebcd707d69a02db1b03708d0175)
    • phpBB/phpbb/storage/storage.php (version 91026b56b9c9cebcd707d69a02db1b03708d0175)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> bb0d705ebf59c4c263b5229488b00cf21e770127

    [ticket/15342] Fix files not being tracked
    PHPBB3-15342

    • phpBB/phpbb/files/filespec_storage.php (version bb0d705ebf59c4c263b5229488b00cf21e770127)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 522ff2f79200b76b9eb34e6327f539aa7c23cf7b

    [ticket/15342] Fix sql condition
    PHPBB3-15342

    • phpBB/phpbb/storage/storage.php (version 522ff2f79200b76b9eb34e6327f539aa7c23cf7b)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 944432d382fb1008fea732252c0bf74047ec6ada

    [ticket/15342] Remove comment since they are a little diferent things
    PHPBB3-15342

    • phpBB/includes/acp/acp_main.php (version 944432d382fb1008fea732252c0bf74047ec6ada)