Build #955

Plan branch:

Build: #955 was successful Changes by Marc

Code commits

phpBB Master

  • Marc

    Marc 37ebf41308dd250a55b6b033919c76282e57ce0c

    Merge pull request #5274 from rubencm/ticket/14285
    [ticket/14285] Move downloads to controller

  • Marc

    Marc fca636ed58a0c78293a486148f902f15c02e4e7f m

    [ticket/14285] Remove no longer needed root_path
    PHPBB3-14285

    • phpBB/phpbb/avatar/driver/upload.php (version fca636ed58a0c78293a486148f902f15c02e4e7f)
  • rubencm

    rubencm 551004a2094660797cf6846b8fff2e20d2cdcaa4 m

    [ticket/14285] Fix code sniffer
    PHPBB3-14285

    • build/code_sniffer/phpbb/Sniffs/Namespaces/UnusedUseSniff.php (version 551004a2094660797cf6846b8fff2e20d2cdcaa4)
  • rubencm

    rubencm 8518b9864e92655ac1f8f23700eb2459e0d49457 m

    [ticket/14285] Move response variable and small improvements
    PHPBB3-14285

    • phpBB/config/default/routing/storage.yml (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/download/file.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/includes/acp/acp_attachments.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/includes/acp/acp_users.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/includes/functions_content.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/includes/functions_posting.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/includes/message_parser.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/includes/ucp/ucp_attachments.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/phpbb/storage/controller/attachment.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/phpbb/storage/controller/avatar.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • phpBB/phpbb/storage/controller/controller.php (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
    • vagrant/after.sh (version 8518b9864e92655ac1f8f23700eb2459e0d49457)
  • rubencm

    rubencm a67f2cf0864643be7468080252cd8ef141cba560 m

    [ticket/14285] Remove no longer needed variable
    PHPBB3-14285

    • phpBB/phpbb/avatar/driver/upload.php (version a67f2cf0864643be7468080252cd8ef141cba560)
    • tests/template/extension_test.php (version a67f2cf0864643be7468080252cd8ef141cba560)
  • rubencm

    rubencm 1e624bef1535e21ac50b81dd6e639039e44e71cd m

    [ticket/14285] Add prefix in routing
    PHPBB3-14285

    • phpBB/config/default/routing/routing.yml (version 1e624bef1535e21ac50b81dd6e639039e44e71cd)
    • phpBB/config/default/routing/storage.yml (version 1e624bef1535e21ac50b81dd6e639039e44e71cd)
    • phpBB/includes/functions_compatibility.php (version 1e624bef1535e21ac50b81dd6e639039e44e71cd)
    • phpBB/phpbb/storage/controller/attachment.php (version 1e624bef1535e21ac50b81dd6e639039e44e71cd)
  • rubencm

    rubencm 31ca404ff7ba5e8734172b9f23a60cb86f1d91d3 m

    [ticket/14285] Fix tests
    PHPBB3-14285

    • tests/functional/feed_test.php (version 31ca404ff7ba5e8734172b9f23a60cb86f1d91d3)
    • tests/test_framework/phpbb_functional_test_case.php (version 31ca404ff7ba5e8734172b9f23a60cb86f1d91d3)
  • rubencm

    rubencm f2914b286937c2810623661c39a3249988745335 m

    [ticket/14285] Fix regular expression
    PHPBB3-14285

    • phpBB/phpbb/feed/helper.php (version f2914b286937c2810623661c39a3249988745335)
  • rubencm

    rubencm c375f2c9e52ba0f817aae4357d89e9c58e69ca29 m

    [ticket/14285] Use route service for download routes
    PHPBB3-14285

    • phpBB/config/default/container/services_avatar.yml (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/includes/acp/acp_attachments.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/includes/acp/acp_users.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/includes/functions_compatibility.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/includes/functions_content.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/includes/functions_posting.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/includes/message_parser.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/includes/ucp/ucp_attachments.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/phpbb/avatar/driver/upload.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • phpBB/phpbb/feed/helper.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • tests/avatar/manager_test.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
    • tests/template/extension_test.php (version c375f2c9e52ba0f817aae4357d89e9c58e69ca29)
  • rubencm

    rubencm f66c1d9e1ebcaefc5a5cf34ebd4d421e690c0450 m

    [ticket/14285] Fix tests
    PHPBB3-14285

    • phpBB/includes/functions_compatibility.php (version f66c1d9e1ebcaefc5a5cf34ebd4d421e690c0450)
    • phpBB/phpbb/storage/controller/attachment.php (version f66c1d9e1ebcaefc5a5cf34ebd4d421e690c0450)
    • phpBB/phpbb/storage/controller/controller.php (version f66c1d9e1ebcaefc5a5cf34ebd4d421e690c0450)
    • tests/download/http_byte_range_test.php (version f66c1d9e1ebcaefc5a5cf34ebd4d421e690c0450)
    • tests/download/http_user_agent_test.php (version f66c1d9e1ebcaefc5a5cf34ebd4d421e690c0450)
  • rubencm

    rubencm 925502a92fef1e53dcf862ec11ac04b609f1f725 m

    [ticket/14285] Move deprecated functions to functions_compatibility.php
    PHPBB3-14285

    • phpBB/includes/functions_compatibility.php (version 925502a92fef1e53dcf862ec11ac04b609f1f725)
    • phpBB/includes/functions_download.php (version 925502a92fef1e53dcf862ec11ac04b609f1f725)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> b1b29cd692c4e58c4279f7b65b81d1ad723ddf60 m

    [ticket/14285] Fix filenames when downloading from controller
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version b1b29cd692c4e58c4279f7b65b81d1ad723ddf60)
  • rubencm

    rubencm b1495bd54aee2a865ec4f39076f01a3d9b4ff337 m

    [ticket/14285] Use private cache-control for atttachments
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version b1495bd54aee2a865ec4f39076f01a3d9b4ff337)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 5c2a8bbfdf3c32085980e1849ac8a259ec80a6b5 m

    [ticket/14285] Remove streamed_response
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/controller.php (version 5c2a8bbfdf3c32085980e1849ac8a259ec80a6b5)
    • phpBB/phpbb/storage/streamed_response.php (version 5c2a8bbfdf3c32085980e1849ac8a259ec80a6b5)
  • rubencm

    rubencm 6f731f0a3e872e51198615237732b97b7fce54e3 m

    [ticket/14285] Apply suggestions
    PHPBB3-14285

    • phpBB/config/default/container/services_storage.yml (version 6f731f0a3e872e51198615237732b97b7fce54e3)
    • phpBB/phpbb/storage/controller/attachment.php (version 6f731f0a3e872e51198615237732b97b7fce54e3)
    • phpBB/phpbb/storage/controller/avatar.php (version 6f731f0a3e872e51198615237732b97b7fce54e3)
    • phpBB/phpbb/storage/controller/controller.php (version 6f731f0a3e872e51198615237732b97b7fce54e3)
  • rubencm

    rubencm 6e345c37a9997e0f6fda8fbf5ac4a6ef26343ae4 m

    [ticket/14285] Don't set cache-control by default
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version 6e345c37a9997e0f6fda8fbf5ac4a6ef26343ae4)
    • phpBB/phpbb/storage/controller/avatar.php (version 6e345c37a9997e0f6fda8fbf5ac4a6ef26343ae4)
    • phpBB/phpbb/storage/controller/controller.php (version 6e345c37a9997e0f6fda8fbf5ac4a6ef26343ae4)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> b2cea59c3e195d877183189ac955cf44c2322b6e m

    [ticket/14285] Add comment
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/controller.php (version b2cea59c3e195d877183189ac955cf44c2322b6e)
  • rubencm

    rubencm e6c6d01e0a6e7f4ed692f66bcb3be1e46576e2c9 m

    [ticket/14284] Update routes
    PHPBB3-14285

    • tests/functional/download_test.php (version e6c6d01e0a6e7f4ed692f66bcb3be1e46576e2c9)
    • tests/functional/feed_test.php (version e6c6d01e0a6e7f4ed692f66bcb3be1e46576e2c9)
  • rubencm

    rubencm 278d4d83188fcedcda57ed42c72a81830e9ae1ba m

    [ticket/14285] Add filename fallback
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version 278d4d83188fcedcda57ed42c72a81830e9ae1ba)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 6f69803a5366bbb1f19d5eddce2700abc5789148 m

    [ticket/14285] Fix return
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/controller.php (version 6f69803a5366bbb1f19d5eddce2700abc5789148)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> ff7c44165d8cca8e2ae7e707852e1ea18f4968fe m

    [ticket/14285] Use request object instead of globals
    PHPBB3-14285

    • phpBB/download/file.php (version ff7c44165d8cca8e2ae7e707852e1ea18f4968fe)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 8725d0b23e3570929c47f276e1f71a100e2ab829 m

    [ticket/14285] Terminate after send file
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/controller.php (version 8725d0b23e3570929c47f276e1f71a100e2ab829)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> d105d222869cd2e00bc7f7568e21c86a530b603a m

    [ticket/14285] Add comments
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version d105d222869cd2e00bc7f7568e21c86a530b603a)
    • phpBB/phpbb/storage/controller/avatar.php (version d105d222869cd2e00bc7f7568e21c86a530b603a)
    • phpBB/phpbb/storage/controller/controller.php (version d105d222869cd2e00bc7f7568e21c86a530b603a)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 26b7180874cd6e7adfb6604648fae308a40fb38a m

    [ticket/14285] Move exit inside callback so the controller can return a response
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/controller.php (version 26b7180874cd6e7adfb6604648fae308a40fb38a)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 034314c0a172979ce1ff266ab9ebed45d433ba9f m

    [ticket/14285] Add comment
    PHPBB3-14285

    • phpBB/phpbb/storage/streamed_response.php (version 034314c0a172979ce1ff266ab9ebed45d433ba9f)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 71403a216e60dd676a9f7dc8f10341ffea5c1e0f m

    [ticket/14285] Remove session management stuff since is already on app.php
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version 71403a216e60dd676a9f7dc8f10341ffea5c1e0f)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 9bb3398c1ed3705cc16caa6044dd1f30040be83c m

    [ticket/14285] Remove unused use
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version 9bb3398c1ed3705cc16caa6044dd1f30040be83c)
    • phpBB/phpbb/storage/controller/avatar.php (version 9bb3398c1ed3705cc16caa6044dd1f30040be83c)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 469f139a2fc4835478ddb32cf329ad8f4d6ca3e5 m

    [ticket/14285] Move code to increment download count
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version 469f139a2fc4835478ddb32cf329ad8f4d6ca3e5)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 05c44e74b3306989cc1e011efb9077630414deb6 m

    [ticket/14285] Use StreamedResponse
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version 05c44e74b3306989cc1e011efb9077630414deb6)
    • phpBB/phpbb/storage/controller/avatar.php (version 05c44e74b3306989cc1e011efb9077630414deb6)
    • phpBB/phpbb/storage/controller/controller.php (version 05c44e74b3306989cc1e011efb9077630414deb6)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> d0fa8014c78d21e7de67050e623f315c4ebfb3e9 m

    [ticket/14285] Update attachment controller
    PHPBB3-14285

    • phpBB/download/file.php (version d0fa8014c78d21e7de67050e623f315c4ebfb3e9)
    • phpBB/phpbb/storage/controller/attachment.php (version d0fa8014c78d21e7de67050e623f315c4ebfb3e9)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 7b678fdbfabc938233e6a2b7a4091a4603a7470c m

    [ticket/14285] Update controllers
    PHPBB3-14285

    • phpBB/config/default/routing/storage.yml (version 7b678fdbfabc938233e6a2b7a4091a4603a7470c)
    • phpBB/phpbb/storage/controller/attachment.php (version 7b678fdbfabc938233e6a2b7a4091a4603a7470c)
    • phpBB/phpbb/storage/controller/controller.php (version 7b678fdbfabc938233e6a2b7a4091a4603a7470c)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 0b136a623174531830da9687444ed2d7c760ff7b m

    [ticket/14285] Remove support for old browsers
    PHPBB3-14285

    • phpBB/includes/functions_download.php (version 0b136a623174531830da9687444ed2d7c760ff7b)
    • phpBB/phpbb/storage/controller/attachment.php (version 0b136a623174531830da9687444ed2d7c760ff7b)
    • phpBB/phpbb/storage/controller/avatar.php (version 0b136a623174531830da9687444ed2d7c760ff7b)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 821964dc7ab6e74d6caeed24ab44c79702db3384 m

    [ticket/14285] Send content-type is application/octet-stream if uknown
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/controller.php (version 821964dc7ab6e74d6caeed24ab44c79702db3384)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 5707d986827f187d8123128236e4178dcec88486 m

    [ticket/14285] Fix undefined property
    PHPBB3-14285

    • phpBB/config/default/container/services_storage.yml (version 5707d986827f187d8123128236e4178dcec88486)
    • phpBB/phpbb/storage/controller/attachment.php (version 5707d986827f187d8123128236e4178dcec88486)
    • phpBB/phpbb/storage/controller/avatar.php (version 5707d986827f187d8123128236e4178dcec88486)
    • phpBB/phpbb/storage/controller/controller.php (version 5707d986827f187d8123128236e4178dcec88486)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> af222e73f36f12299e4a0befa41cf1107debc8dc m

    [ticket/14285] Remove support for old browsers
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version af222e73f36f12299e4a0befa41cf1107debc8dc)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 0e92744fa4ea44b6d8e54081f6272dfc8cb982f2 m

    [ticket/14285] Remove flash support
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version 0e92744fa4ea44b6d8e54081f6272dfc8cb982f2)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> d11b83a4c54a0822076d6124e9fc3186fb136bfb m

    [ticket/14285] Remove useless variable of event
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/attachment.php (version d11b83a4c54a0822076d6124e9fc3186fb136bfb)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> dc1d3683a8fb2151e8c80c3c6d3e9bfae9ada360 m

    [ticket/14285] Update controllers
    PHPBB3-14285

    • phpBB/config/default/container/services_storage.yml (version dc1d3683a8fb2151e8c80c3c6d3e9bfae9ada360)
    • phpBB/download/file.php (version dc1d3683a8fb2151e8c80c3c6d3e9bfae9ada360)
    • phpBB/phpbb/storage/controller/attachment.php (version dc1d3683a8fb2151e8c80c3c6d3e9bfae9ada360)
    • phpBB/phpbb/storage/controller/avatar.php (version dc1d3683a8fb2151e8c80c3c6d3e9bfae9ada360)
    • phpBB/phpbb/storage/controller/controller.php (version dc1d3683a8fb2151e8c80c3c6d3e9bfae9ada360)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 6232401dd73344f8d3e2794cd2bda95254fdc60a m

    [ticket/14285] Rename argument from file to id
    PHPBB3-14285

    • phpBB/config/default/routing/storage.yml (version 6232401dd73344f8d3e2794cd2bda95254fdc60a)
    • phpBB/download/file.php (version 6232401dd73344f8d3e2794cd2bda95254fdc60a)
    • phpBB/phpbb/storage/controller/attachment.php (version 6232401dd73344f8d3e2794cd2bda95254fdc60a)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 4abdabe6f4bd032484db2bffcd3dd2fec791eca3 m

    [ticket/14285] Temporal fix for StreamedResponse
    PHPBB3-14285

    • phpBB/phpbb/storage/controller/controller.php (version 4abdabe6f4bd032484db2bffcd3dd2fec791eca3)
    • phpBB/phpbb/storage/streamed_response.php (version 4abdabe6f4bd032484db2bffcd3dd2fec791eca3)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 2f043cdb612f197160d08d84e58682dd010ab4ef m

    [ticket/14285] Move functions from functions_download to controller
    PHPBB3-14285

    • phpBB/config/default/container/services_storage.yml (version 2f043cdb612f197160d08d84e58682dd010ab4ef)
    • phpBB/includes/functions_download.php (version 2f043cdb612f197160d08d84e58682dd010ab4ef)
    • phpBB/phpbb/storage/controller/attachment.php (version 2f043cdb612f197160d08d84e58682dd010ab4ef)
    • phpBB/phpbb/storage/controller/avatar.php (version 2f043cdb612f197160d08d84e58682dd010ab4ef)
    • phpBB/phpbb/storage/controller/controller.php (version 2f043cdb612f197160d08d84e58682dd010ab4ef)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> 8dcf8a4ddb9afaf767cbf0995d669b3434e860d4 m

    [ticket/14285] Remove support for old internet explorer versions
    PHPBB3-14285

    • phpBB/includes/functions_download.php (version 8dcf8a4ddb9afaf767cbf0995d669b3434e860d4)
    • phpBB/phpbb/storage/controller/attachment.php (version 8dcf8a4ddb9afaf767cbf0995d669b3434e860d4)
  • Rubén Calvo <rubencm@gmail.com>

    Rubén Calvo <rubencm@gmail.com> dd069333244db94285b1619ba6be437484c19989 m

    [ticket/14285] Move downloads to controller
    PHPBB3-14285

    • phpBB/config/default/container/services_storage.yml (version dd069333244db94285b1619ba6be437484c19989)
    • phpBB/config/default/routing/routing.yml (version dd069333244db94285b1619ba6be437484c19989)
    • phpBB/config/default/routing/storage.yml (version dd069333244db94285b1619ba6be437484c19989)
    • phpBB/download/file.php (version dd069333244db94285b1619ba6be437484c19989)
    • phpBB/includes/functions_download.php (version dd069333244db94285b1619ba6be437484c19989)
    • phpBB/phpbb/storage/controller/attachment.php (version dd069333244db94285b1619ba6be437484c19989)
    • phpBB/phpbb/storage/controller/avatar.php (version dd069333244db94285b1619ba6be437484c19989)
    • phpBB/phpbb/storage/controller/controller.php (version dd069333244db94285b1619ba6be437484c19989)