Build #1,437

Plan branch:

Build: #1437 was successful

Job: PHP 8.1 - SQLite Package was successful

Stages & jobs

  1. Default Stage

Code commits

phpBB Master

  • Marc

    Marc 4367bc8d11159b876100f63c8e316b66af4ec64c

    Merge pull request #6830 from rxu/ticket/17525
    [ticket/17525] Correctly handle Doctrine DB tools exceptions, enrich error info

  • rxu

    rxu aa3f266b8c71832f5821746bfbfe156147d46a93 m

    [ticket/17525] Address the PR review comments
    PHPBB-17525

    • phpBB/adm/style/acp_ext_delete_data.html (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • phpBB/adm/style/acp_ext_enable.html (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • phpBB/includes/acp/acp_extensions.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • phpBB/phpbb/db/doctrine/table_helper.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • phpBB/phpbb/db/tools/doctrine.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • phpBB/phpbb/db/tools/tools_interface.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • tests/captcha/qa_test.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • tests/console/user/base.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • tests/dbal/auto_increment_test.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • tests/migrator/convert_timezones_test.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • tests/notification/convert_test.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
    • tests/search/native_test.php (version aa3f266b8c71832f5821746bfbfe156147d46a93)
  • rxu

    rxu 10921ebc582a10fdedb6dcd066695bdf3ec6eefc m

    [ticket/17525] Fix migration failure on update
    PHPBB-17525

    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version 10921ebc582a10fdedb6dcd066695bdf3ec6eefc)
    • phpBB/phpbb/db/migration/migration.php (version 10921ebc582a10fdedb6dcd066695bdf3ec6eefc)
  • rxu

    rxu 5eaabb1c39303d202f9c7f1af34700325d83e491 m

    [ticket/17525] Fix handling index name prefix logic for renaming
    PHPBB-17525

    • phpBB/develop/create_schema_files.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • phpBB/phpbb/db/doctrine/table_helper.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • phpBB/phpbb/db/tools/doctrine.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • phpBB/phpbb/db/tools/tools_interface.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • phpBB/phpbb/install/helper/database.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • phpBB/phpbb/install/module/install_database/task/add_tables.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • phpBB/phpbb/install/module/install_database/task/create_schema_file.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/captcha/qa_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/console/user/base.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/dbal/auto_increment_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/dbal/db_tools_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/dbal/migrator_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/extension/manager_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/extension/metadata_manager_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/migrations/migrations_check_config_added_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/migrator/convert_timezones_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/migrator/get_callable_from_step_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/migrator/schema_generator_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/notification/convert_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/search/native_test.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/test_framework/phpbb_database_test_case.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/test_framework/phpbb_database_test_connection_manager.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
    • tests/test_framework/phpbb_functional_test_case.php (version 5eaabb1c39303d202f9c7f1af34700325d83e491)
  • rxu

    rxu b5c3befa87dac47c12dc23228a9a35c4090e4fdc m

    [ticket/17525] Fix handling index name prefix logic for renaming
    PHPBB-17525

    • phpBB/phpbb/db/tools/doctrine.php (version b5c3befa87dac47c12dc23228a9a35c4090e4fdc)
  • rxu

    rxu 669af8f3aa308e4b8f6d001fc5fba629fb67fa1d m

    [ticket/17525] Automatically handle index name prefixes
    PHPBB-17525

    • phpBB/phpbb/db/tools/doctrine.php (version 669af8f3aa308e4b8f6d001fc5fba629fb67fa1d)
    • tests/dbal/db_tools_test.php (version 669af8f3aa308e4b8f6d001fc5fba629fb67fa1d)
  • rxu

    rxu 8e0ec1edd27ce4f7830d540729fa33056ad0df2c m

    [ticket/17525] Automatically handle index name prefixes
    PHPBB-17525

    • phpBB/phpbb/db/doctrine/table_helper.php (version 8e0ec1edd27ce4f7830d540729fa33056ad0df2c)
    • phpBB/phpbb/db/tools/doctrine.php (version 8e0ec1edd27ce4f7830d540729fa33056ad0df2c)
    • phpBB/phpbb/db/tools/tools_interface.php (version 8e0ec1edd27ce4f7830d540729fa33056ad0df2c)
  • rxu

    rxu e9157f4d10f96f5d921ede7c87a101475b1e611f m

    [ticket/17525] Fix tests
    PHPBB-17525

    • phpBB/phpbb/db/tools/doctrine.php (version e9157f4d10f96f5d921ede7c87a101475b1e611f)
    • phpBB/phpbb/db/tools/tools_interface.php (version e9157f4d10f96f5d921ede7c87a101475b1e611f)
    • tests/dbal/migrator_test.php (version e9157f4d10f96f5d921ede7c87a101475b1e611f)
  • rxu

    rxu 4274faa7155a71cd9bbbdcfed39c2c337e45c217 m

    [ticket/17525] Provide Doctrine connection via dbtools
    PHPBB-17525

    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version 4274faa7155a71cd9bbbdcfed39c2c337e45c217)
    • phpBB/phpbb/db/migration/migration.php (version 4274faa7155a71cd9bbbdcfed39c2c337e45c217)
    • phpBB/phpbb/db/tools/doctrine.php (version 4274faa7155a71cd9bbbdcfed39c2c337e45c217)
  • rxu

    rxu 1cadb3818af3cf891722ba9bffc526d9ba098e6c m

    [ticket/17525] Provide Doctrine connection object for migrations
    PHPBB-17525

    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version 1cadb3818af3cf891722ba9bffc526d9ba098e6c)
    • phpBB/phpbb/db/migration/migration.php (version 1cadb3818af3cf891722ba9bffc526d9ba098e6c)
  • rxu

    rxu 58b3e5dee04f26f5a160e765691fe7401ee0e0db m

    [ticket/17525] Migration to rename actual database indexes if any
    Also generate short table names rather than use hardcoded map

    PHPBB-17525

    • phpBB/phpbb/db/doctrine/table_helper.php (version 58b3e5dee04f26f5a160e765691fe7401ee0e0db)
    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version 58b3e5dee04f26f5a160e765691fe7401ee0e0db)
  • rxu

    rxu 4da8591dd8a47d917ed2aa39830c71d71cb5f718 m

    [ticket/17525] Run index renaming migration the last in migrations queue
    PHPBB-17525

    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version 4da8591dd8a47d917ed2aa39830c71d71cb5f718)
  • rxu

    rxu 5e9d616f5760812cd5ed6b63dca0fefb4adf0b78 m

    [ticket/17525] Map Sphinx table, add more test assertions
    PHPBB-17525

    • phpBB/phpbb/db/doctrine/table_helper.php (version 5e9d616f5760812cd5ed6b63dca0fefb4adf0b78)
    • tests/dbal/migrator_test.php (version 5e9d616f5760812cd5ed6b63dca0fefb4adf0b78)
  • rxu

    rxu de1f6329ff7dae141bb0073a0be8604a5c7dd525 m

    [ticket/17525] Fix tests
    PHPBB-17525

    • phpBB/phpbb/db/doctrine/table_helper.php (version de1f6329ff7dae141bb0073a0be8604a5c7dd525)
    • tests/dbal/migrator_test.php (version de1f6329ff7dae141bb0073a0be8604a5c7dd525)
  • rxu

    rxu 75c5fe9459260e91e8887cc68e845865a0d6490b m

    [ticket/17525] Add index names test for generated database schema
    PHPBB-17525

    • phpBB/phpbb/db/doctrine/table_helper.php (version 75c5fe9459260e91e8887cc68e845865a0d6490b)
    • tests/dbal/migrator_test.php (version 75c5fe9459260e91e8887cc68e845865a0d6490b)
  • rxu

    rxu a229797cd756e6b05a735709ca13649a2fb3cf86 m

    [ticket/17525] Add database schema getter
    PHPBB-17525

    • phpBB/phpbb/db/doctrine/table_helper.php (version a229797cd756e6b05a735709ca13649a2fb3cf86)
    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version a229797cd756e6b05a735709ca13649a2fb3cf86)
  • rxu

    rxu 1339a31c2369ed545dc086873e644bb28b5bce1b m

    [ticket/17525] Rename all indexes to make names unique
    With this reNAMING schema, max index name length is 23.

    PHPBB-17525

    • phpBB/phpbb/db/doctrine/table_helper.php (version 1339a31c2369ed545dc086873e644bb28b5bce1b)
    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version 1339a31c2369ed545dc086873e644bb28b5bce1b)
  • rxu

    rxu 45a69eca140895981b41fc8b4ca2b6870aad8cfc m

    [ticket/17525] Rename migration to reflect its purpose
    PHPBB-17525

    • phpBB/phpbb/db/migration/data/v400/rename_duplicated_index_names.php (version 45a69eca140895981b41fc8b4ca2b6870aad8cfc)
  • rxu

    rxu 84d195ac218bfc09c76f588131cb921864a614ca m

    [ticket/17525] Add migration renaming index test
    PHPBB-17525

    • tests/dbal/migration/schema_index.php (version 84d195ac218bfc09c76f588131cb921864a614ca)
    • tests/dbal/migrator_test.php (version 84d195ac218bfc09c76f588131cb921864a614ca)
  • rxu

    rxu 78dcb0c86207b182d8abd517880e5057ca3a3f85 m

    [ticket/17525] Avoid more index name duplication
    PHPBB-17525

    • phpBB/phpbb/db/migration/data/v400/rename_auth_role_id_index.php (version 78dcb0c86207b182d8abd517880e5057ca3a3f85)
  • rxu

    rxu 7b0b95250c56171bca3a7d490b81a2f265a0e36b m

    [ticket/17525] Avoid more index name duplication
    Many more tables have indexes with the same names which can cause issues
    on SQLite/Postgres. Also, add an option for migrations to rename indexes.

    PHPBB-17525

    • phpBB/phpbb/db/migration/data/v400/rename_auth_role_id_index.php (version 7b0b95250c56171bca3a7d490b81a2f265a0e36b)
    • phpBB/phpbb/db/migration/helper.php (version 7b0b95250c56171bca3a7d490b81a2f265a0e36b)
    • phpBB/phpbb/db/migration/schema_generator.php (version 7b0b95250c56171bca3a7d490b81a2f265a0e36b)
    • phpBB/phpbb/db/tools/doctrine.php (version 7b0b95250c56171bca3a7d490b81a2f265a0e36b)
    • phpBB/phpbb/db/tools/tools_interface.php (version 7b0b95250c56171bca3a7d490b81a2f265a0e36b)
  • rxu

    rxu 0e0214a71da29a33e83de466245166ff4942fd27 m

    [ticket/17525] Avoid index name duplication (auth_role_id)
    phpbb_acl_groups and phpbb_acl_users have indexes
    with the same names (auth_role_id) which can cause issues on SQLite/Postgres

    PHPBB-17525

    • phpBB/phpbb/db/migration/data/v400/rename_auth_role_id_index.php (version 0e0214a71da29a33e83de466245166ff4942fd27)
  • rxu

    rxu 8d1f8af7c65d0a7a4645dad763c4e48a92d0ef82 m

    [ticket/17525] Correctly handle Doctrine DB tools exceptions, enrich error info
    PHPBB-17525

    • phpBB/includes/acp/acp_extensions.php (version 8d1f8af7c65d0a7a4645dad763c4e48a92d0ef82)
    • phpBB/includes/functions.php (version 8d1f8af7c65d0a7a4645dad763c4e48a92d0ef82)
    • phpBB/install/startup.php (version 8d1f8af7c65d0a7a4645dad763c4e48a92d0ef82)
    • phpBB/phpbb/db/tools/doctrine.php (version 8d1f8af7c65d0a7a4645dad763c4e48a92d0ef82)
    • phpBB/phpbb/install/installer.php (version 8d1f8af7c65d0a7a4645dad763c4e48a92d0ef82)